Re: [gentoo-portage-dev] [PATCH 1/2] Use a localized size formatting function and ISO/IEC prefixes.

2014-03-30 Thread Alec Warner
On Sun, Mar 30, 2014 at 12:56 AM, Michał Górny wrote: > Dnia 2014-03-30, o godz. 00:03:02 > Alexander Berntsen napisał(a): > > > -BEGIN PGP SIGNED MESSAGE- > > Hash: SHA256 > > > > Please use a max 50 char commit message headline, without the period. > > > > On 29/03/14 19:45, Michał Gór

Re: [gentoo-portage-dev] [PATCH 1/2] Use a localized size formatting function and ISO/IEC prefixes.

2014-03-30 Thread Brian Dolbec
On Sun, 30 Mar 2014 09:56:11 +0200 Michał Górny wrote: > Dnia 2014-03-30, o godz. 00:03:02 > Alexander Berntsen napisał(a): > > > -BEGIN PGP SIGNED MESSAGE- > > Hash: SHA256 > > > > Please use a max 50 char commit message headline, without the > > period. > > > > On 29/03/14 19:45, Mi

Re: [gentoo-portage-dev] [PATCH 1/2] Use a localized size formatting function and ISO/IEC prefixes.

2014-03-30 Thread Michał Górny
Dnia 2014-03-30, o godz. 00:03:02 Alexander Berntsen napisał(a): > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Please use a max 50 char commit message headline, without the period. > > On 29/03/14 19:45, Michał Górny wrote: > > +import locale +import math > Why not explicitly import w

Re: [gentoo-portage-dev] [PATCH 1/2] Use a localized size formatting function and ISO/IEC prefixes.

2014-03-29 Thread Alexander Berntsen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Please use a max 50 char commit message headline, without the period. On 29/03/14 19:45, Michał Górny wrote: > +import locale +import math Why not explicitly import what you are going to use? (On the form of "from foo import bar, baz".) - -- Alexan

[gentoo-portage-dev] [PATCH 1/2] Use a localized size formatting function and ISO/IEC prefixes.

2014-03-29 Thread Michał Górny
A similar size formatting function was used in two places in emerge code. Instead, create a single function in portage.localization module that formats sizes using the current locale and a common set of rules. I'm not really convinced about 'ceiling' all sizes but I understand the original point a