Re: [gentoo-portage-dev] [PATCH 1/4] portage.dep.Atom: Clean up __new__ parameters

2022-03-08 Thread Alec Warner
maybe *unused_args, **unused_kwargs, unsure on the style guide for
that (normally its _)

But feel free to merge as-is.

-A

On Wed, Feb 23, 2022 at 8:15 PM Matt Turner  wrote:
>
> From: "Wolfgang E. Sanyer" 
>
> Reviewed-by: Matt Turner 
> Signed-off-by: Wolfgang E. Sanyer 
> ---
>  lib/portage/dep/__init__.py | 12 +---
>  1 file changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/lib/portage/dep/__init__.py b/lib/portage/dep/__init__.py
> index 3b3577025..13c0f4ef7 100644
> --- a/lib/portage/dep/__init__.py
> +++ b/lib/portage/dep/__init__.py
> @@ -1489,17 +1489,7 @@ class Atom(str):
>  def __init__(self, forbid_overlap=False):
>  self.overlap = self._overlap(forbid=forbid_overlap)
>
> -def __new__(
> -cls,
> -s,
> -unevaluated_atom=None,
> -allow_wildcard=False,
> -allow_repo=None,
> -_use=None,
> -eapi=None,
> -is_valid_flag=None,
> -allow_build_id=None,
> -):
> +def __new__(cls, s, *args, **kwargs):
>  return str.__new__(cls, s)
>
>  def __init__(
> --
> 2.34.1
>
>



[gentoo-portage-dev] [PATCH 1/4] portage.dep.Atom: Clean up __new__ parameters

2022-02-23 Thread Matt Turner
From: "Wolfgang E. Sanyer" 

Reviewed-by: Matt Turner 
Signed-off-by: Wolfgang E. Sanyer 
---
 lib/portage/dep/__init__.py | 12 +---
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/lib/portage/dep/__init__.py b/lib/portage/dep/__init__.py
index 3b3577025..13c0f4ef7 100644
--- a/lib/portage/dep/__init__.py
+++ b/lib/portage/dep/__init__.py
@@ -1489,17 +1489,7 @@ class Atom(str):
 def __init__(self, forbid_overlap=False):
 self.overlap = self._overlap(forbid=forbid_overlap)
 
-def __new__(
-cls,
-s,
-unevaluated_atom=None,
-allow_wildcard=False,
-allow_repo=None,
-_use=None,
-eapi=None,
-is_valid_flag=None,
-allow_build_id=None,
-):
+def __new__(cls, s, *args, **kwargs):
 return str.__new__(cls, s)
 
 def __init__(
-- 
2.34.1