Re: [gentoo-portage-dev] [PATCH v2] eend: Output QA notice when called without argument

[Ulrich Mueller]

> On Sat, 04 Sep 2021, Ulrich Müller wrote:

> PMS says about eend: "Takes one fixed argument, which is a numeric
> return code, and an optional message in all subsequent arguments."

Pushed.


signature.asc
Description: PGP signature

[gentoo-portage-dev] [PATCH v2] eend: Output QA notice when called without argument

[Ulrich Müller]

PMS says about eend: "Takes one fixed argument, which is a numeric
return code, and an optional message in all subsequent arguments."

Bug: https://bugs.gentoo.org/703520
Signed-off-by: Ulrich Müller 
---
 bin/isolated-functions.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/bin/isolated-functions.sh b/bin/isolated-functions.sh
index b495ae6c7..5630dcf4c 100644
--- a/bin/isolated-functions.sh
+++ b/bin/isolated-functions.sh
@@ -364,6 +364,7 @@ __eend() {
 }
 
 eend() {
+   [[ -n $1 ]] || eqawarn "QA Notice: eend called without first argument"
local retval=${1:-0}
shift
 
-- 
2.33.0