Re: [gentoo-portage-dev] [PATCH v2] repoman: declare '-x', '--xmlparse' command line options obsolete
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512
When submitting v2-patches, please submit them in-reply-to=the message
ID of the original thread.
The patch looks OK, but I don't recall us using the "OBSOLETE" phrase
in any documentation. Does anybody know any phrase we should be using
instead, and why we should be using that phrase instead?
Maybe we should pick a term ("OBSOLETE" is fine by me), and make it
"official" for these situations in the future.
- --
Alexander
berna...@gentoo.org
https://secure.plaimi.net/~alexander
-BEGIN PGP SIGNATURE-
Version: GnuPG v2
iQIcBAEBCgAGBQJXQuHFAAoJENQqWdRUGk8B74sP/3gMywA7AWshVzsyzEA2PRf2
LNaW0vb98zSq5DbRuqN5624i83g20wk2GHNm/8ZqS1yuTrjNmJ3XjXJriQwCIryL
cJTvz0FxrOdGcmT7/SWTI3vT0P6yOA5s+rrNp8jBPqeDQFAcy8eZbTDa8A9KtWmZ
w6ZQ+ht3mQqLt3VkADDbzqX5/w1szi8isQXkFFKUn4en54A9KQsmsFWRqKYNpUPK
7HXSTHhvPtSyoYxjBxKVd+chbDHVFbIqVWuuJfoSro3RiKDnCjzxYjuqcP8mRxfp
s9O0LCynAwWBrTQwBJd0FRPp5Y95vRENCP+18XnT4cI3S+2TdJAptW+MfZrAXKz/
9OKJfuwkdvpOqdNtpk0mmbe19CIiCEFiZXP+wC+8JtyuEE+gwfUJaPbz5MFNLqRo
TLPHvjphrtmyvasa8ZxocB7mF9uCwZSaPbxf0jr80axvBcVZPREY/a15SbOJliZI
mBzqxto1mX6idWONMLIhWwwwV0SMEkOTxl4Osh/De2FbnSW47rOQxJdXs0jXQXW/
KOlVX7h7PzQ7KqS9lDpHJsyRMseRPMq3BTfwW+pMs3qwKEDg2Ge4p1E8aGv7Bjj8
LoPvPuGV2Vy51ZzowMqHxQzYTXdnHq33TDI8M/1qaJaIdrhSsGbmcoJt2YQuXPkE
d+6/eMbY0YERDJ6FTofe
=eAJu
-END PGP SIGNATURE-
[gentoo-portage-dev] [PATCH v2] repoman: declare '-x', '--xmlparse' command line options obsolete
Repoman pulls in lxml unconditionally now and performs metadata checks
by default. This behavior makes these command line options obsolete
since forcing the default makes little sense. Declare them obsolete
instead of removing them for backwards compatibility.
---
repoman/man/repoman.1| 2 +-
repoman/pym/repoman/argparser.py | 4 +++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/repoman/man/repoman.1 b/repoman/man/repoman.1
index e2b9c66..88b3e5e 100644
--- a/repoman/man/repoman.1
+++ b/repoman/man/repoman.1
@@ -60,7 +60,7 @@ Be less verbose about extraneous info
Don't commit or fix anything; just show what would be done
.TP
\fB-x\fR, \fB--xmlparse\fR
-Forces the metadata.xml parse check to be carried out
+(OBSOLETE, always enabled) Forces the metadata.xml parse check to be carried
out
.TP
\fB-v\fR, \fB--verbose\fR
Displays every package name while checking
diff --git a/repoman/pym/repoman/argparser.py b/repoman/pym/repoman/argparser.py
index 2d56a87..32758aa 100644
--- a/repoman/pym/repoman/argparser.py
+++ b/repoman/pym/repoman/argparser.py
@@ -117,7 +117,9 @@ def parse_args(argv, qahelp, repoman_default_opts):
parser.add_argument(
'-x', '--xmlparse', dest='xml_parse', action='store_true',
default=False,
- help='forces the metadata.xml parse check to be carried out')
+ help=(
+ '(OBSOLETE, always enabled) '
+ 'forces the metadata.xml parse check to be carried
out'))
parser.add_argument(
'--if-modified', choices=('y', 'n'), default='n',
--
2.7.3
