Re: [gentoo-portage-dev] --nospinner in emerge_default_opts

2006-01-30 Thread Zac Medico
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

William Hubbs wrote:
> I just ran a test with this again, and it does look like "--nospinner"
> is not allowed in emerge_default_opts.

Thank you, this is indeed a bug and I've committed a fix to trunk (2.1_preX).  
You can wait for the next release or use the attached patch if you'd like.

Zac
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.2 (GNU/Linux)

iD8DBQFD3g1N/ejvha5XGaMRArfXAJoCKz5Uv+vBRQK3YKwOeY2UVmsrlQCg5urO
wTZY9YRMQGMKQgMjvbSzcjA=
=9oR9
-END PGP SIGNATURE-
Index: bin/emerge
===
--- bin/emerge  (revision 2606)
+++ bin/emerge  (working copy)
@@ -72,10 +72,7 @@
 if "candy" in portage.settings.features:
spinner = spinner_msgs[int(time.time()*100)%len(spinner_msgs)]
update_spinner = update_scroll_spinner
-if not sys.stdout.isatty() or ("--nospinner" in sys.argv):
-   update_spinner = update_basic_spinner

-
 if (not sys.stdout.isatty()) or (portage.settings["NOCOLOR"] in ["yes","true"]):
nocolor()

@@ -431,6 +428,9 @@
 if ("--nocolor" in myopts) and (sys.stdout.isatty()):
nocolor()

+if not sys.stdout.isatty() or ("--nospinner" in myopts):
+   update_spinner = update_basic_spinner
+
 CLEAN_DELAY = 5
 EMERGE_WARNING_DELAY = 10
 if portage.settings["CLEAN_DELAY"]:


Re: [gentoo-portage-dev] --nospinner in emerge_default_opts

2006-01-28 Thread Alec Warner
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Andrew Gaffney wrote:
> William Hubbs wrote:
> 
>> I just ran a test with this again, and it does look like "--nospinner"
>> is not allowed in emerge_default_opts.
>>
>> If this should be filed as a bug, let me know, or if it isn't a bug,
>> would it be possible to allow this option?

If in doubt, file one and if it isn't one we can always close it later.
Just double check that you can reproduce the outcome.

> 
> 
> Is there a reason you can't just alias it?
> 

Er, if it's a bug it's a bug ;)  Although that is probably a solution in
the meantime :)

- -Alec Warner (antarus)
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iQIVAwUBQ9wn32zglR5RwbyYAQKMwBAAkMsuOiscuSnOH92/8hpbWljI+bCM2EWz
8RAGv7yJX3CohhmmZLTMWuimJFmrwHuu8eVddZlzVeBacv/oCuu2faP0HenKnejc
iXmIW5pGMYDY7W/dy5bW7lPfrU610kV/ePhnnVjSXBL8kpTBVJu56bOcSVQBD0S9
3xDPfzk4Rj0PYJtv+pUtqKjcFsCku2hnEDIa4j1kYbJxJU6acFVrCbaD8VQ1F6Sz
nGYbMpWnvv17vhie++i1/HkIZ2QXnyIVxzYudkbMjzYU+Dwyhkts4zvrOQixI3jN
OzC8SdNUbjs2BMQ5932DgrroY63aLBKUjNbqKFdeS/sAhXe578kFfLZvI/HVSYK2
WC0ywoeuGZX/ZischYaHfCnOPAtRLwMeLab62/3+e0niuHaN4lvdGXjHTv+dzl4x
jUVw5NEUZCgOCNK/aTYmVcx+0OUAQaskRIdINCBqNTuelAAmqo94XfdHqfJKLfve
LVoPqS2dQQp9Wj4akQiEVZgihrPtNtaTQS7q7BA2BUJCcGpSyAVmOZ/hHmByd5nJ
mSkEBuSr22hLl9xF+BMEZvldw2t7fi3uBczC4fUC81O4jd9fDjqlEpS/o6wdKtUP
Q8Z3oanNoP4Ao2seL9ZWx6+H2RnwvwnqwQqRAmkH1BAljpNTtowDdxwooWc81NAW
jVJsCbhFYRg=
=81H2
-END PGP SIGNATURE-
-- 
gentoo-portage-dev@gentoo.org mailing list



Re: [gentoo-portage-dev] --nospinner in emerge_default_opts

2006-01-28 Thread Andrew Gaffney

William Hubbs wrote:

I just ran a test with this again, and it does look like "--nospinner"
is not allowed in emerge_default_opts.

If this should be filed as a bug, let me know, or if it isn't a bug,
would it be possible to allow this option?


Is there a reason you can't just alias it?

--
Andrew Gaffneyhttp://dev.gentoo.org/~agaffney/
Gentoo Linux Developer   Installer Project
--
gentoo-portage-dev@gentoo.org mailing list



[gentoo-portage-dev] --nospinner in emerge_default_opts

2006-01-28 Thread William Hubbs
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

All,

I just ran a test with this again, and it does look like "--nospinner"
is not allowed in emerge_default_opts.

If this should be filed as a bug, let me know, or if it isn't a bug,
would it be possible to allow this option?

Thanks much,

William

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.2 (GNU/Linux)

iD8DBQFD2/XfblQW9DDEZTgRAtjrAKCrvhdcQ90s0+LGDqTyMbghi1zoVACeJi/O
m5bQGPGGu7d1SBdwoV7LR+w=
=3uIO
-END PGP SIGNATURE-
-- 
gentoo-portage-dev@gentoo.org mailing list