Re: [gentoo-portage-dev] About adding a repoman check to test for missing files in FILESDIR

[Fabian Groffen]

On 08-10-2012 20:47:41 +0200, Pacho Ramos wrote:
 El lun, 08-10-2012 a las 11:32 -0700, Zac Medico escribió:
  Given the expressiveness of the bash language, it's really a non-trivial
  thing to check without actually executing bash. See discussion here:
  
https://bugs.gentoo.org/show_bug.cgi?id=431196
 
 Then, maybe I could have a custom repoman script that would check for
 them in my files/ directory (either using bash to check for them or
 simply running ls)  :/

Yes, but still it is very hard to make it 100% reliable.  If you stick
to simple ${FILESDIR}/${PN}-x.y.patch patterns, it's very well
feasible, though.  See for inspiration the fetch_files() function from [1].


[1] 
http://overlays.gentoo.org/proj/alt/browser/trunk/prefix-overlay/scripts/eupdate.in


-- 
Fabian Groffen
Gentoo on a different level


signature.asc
Description: Digital signature

[gentoo-portage-dev] About adding a repoman check to test for missing files in FILESDIR

[Pacho Ramos]

Hello

Sometime ago this was already discussed but, if I don't misremember, it
was hard to implement a check for repoman to prevent us from forgetting
to commit new patches. Maybe the check could simply check if all
${FILESDIR} files are present? The idea is that it could simply check
of that files existence, if they are not present, show a warn (not a
hard warn as it could be a false positive I guess). Regarding that
file not being added to cvs tree, it doesn't show so much problems as
that error is already shown at commit time (file present but not added
to cvs)

Thanks


signature.asc
Description: This is a digitally signed message part

Re: [gentoo-portage-dev] About adding a repoman check to test for missing files in FILESDIR

[Zac Medico]

On 10/08/2012 11:26 AM, Pacho Ramos wrote:
 Hello
 
 Sometime ago this was already discussed but, if I don't misremember, it
 was hard to implement a check for repoman to prevent us from forgetting
 to commit new patches. Maybe the check could simply check if all
 ${FILESDIR} files are present? The idea is that it could simply check
 of that files existence, if they are not present, show a warn (not a
 hard warn as it could be a false positive I guess). Regarding that
 file not being added to cvs tree, it doesn't show so much problems as
 that error is already shown at commit time (file present but not added
 to cvs)

Given the expressiveness of the bash language, it's really a non-trivial
thing to check without actually executing bash. See discussion here:

  https://bugs.gentoo.org/show_bug.cgi?id=431196
-- 
Thanks,
Zac

Re: [gentoo-portage-dev] About adding a repoman check to test for missing files in FILESDIR

[Pacho Ramos]

El lun, 08-10-2012 a las 11:32 -0700, Zac Medico escribió:
 On 10/08/2012 11:26 AM, Pacho Ramos wrote:
  Hello
  
  Sometime ago this was already discussed but, if I don't misremember, it
  was hard to implement a check for repoman to prevent us from forgetting
  to commit new patches. Maybe the check could simply check if all
  ${FILESDIR} files are present? The idea is that it could simply check
  of that files existence, if they are not present, show a warn (not a
  hard warn as it could be a false positive I guess). Regarding that
  file not being added to cvs tree, it doesn't show so much problems as
  that error is already shown at commit time (file present but not added
  to cvs)
 
 Given the expressiveness of the bash language, it's really a non-trivial
 thing to check without actually executing bash. See discussion here:
 
   https://bugs.gentoo.org/show_bug.cgi?id=431196

Then, maybe I could have a custom repoman script that would check for
them in my files/ directory (either using bash to check for them or
simply running ls)  :/


signature.asc
Description: This is a digitally signed message part