Re: [gentoo-portage-dev] making dodoc and dohtml die when they fail and stricter is on

2005-12-25 Thread Brian Harring 
On Mon, Dec 26, 2005 at 12:54:04AM +0200, Petteri Räty wrote:
> Currently there are quite a few ebuilds in the tree that execute dodoc
> or dohtml for files that do not exist. I think it would be nice to have
> ebuilds die if this is the case. To not break current ebuilds this would
> only happen with FEATURES="stricter". This is what I currently do in my
> bashrc. Obviously when integreted to portage one can use helper
> functions like hasq which are not available in bashrc.
> 
> 
> if [[ "${FEATURES/stricter}" != "${FEATURES}" ]]; then
> 
> _makefail() {
>   bin="/usr/lib/portage/bin/${1}"
>   shift 1
>   "${bin}" "[EMAIL PROTECTED]" || die "${bin} [EMAIL PROTECTED] failed"
> }
> 
> dodoc() { _makefail ${FUNCNAME} "[EMAIL PROTECTED]"; }
> dohtml() {_makefail ${FUNCNAME} "[EMAIL PROTECTED]"; }
Seems like more of a -dev discussion imo, since they're the ones 
affected by it (for us it's just an api change).
~harring


pgpxdjyp8NzBA.pgp
Description: PGP signature

[gentoo-portage-dev] making dodoc and dohtml die when they fail and stricter is on

2005-12-25 Thread Petteri Räty 
Currently there are quite a few ebuilds in the tree that execute dodoc
or dohtml for files that do not exist. I think it would be nice to have
ebuilds die if this is the case. To not break current ebuilds this would
only happen with FEATURES="stricter". This is what I currently do in my
bashrc. Obviously when integreted to portage one can use helper
functions like hasq which are not available in bashrc.


if [[ "${FEATURES/stricter}" != "${FEATURES}" ]]; then

_makefail() {
bin="/usr/lib/portage/bin/${1}"
shift 1
"${bin}" "[EMAIL PROTECTED]" || die "${bin} [EMAIL PROTECTED] failed"
}

dodoc() {   _makefail ${FUNCNAME} "[EMAIL PROTECTED]"; }
dohtml() {  _makefail ${FUNCNAME} "[EMAIL PROTECTED]"; }

fi

Regards,
Petteri


signature.asc
Description: OpenPGP digital signature