Re: [gentoo-portage-dev] [PATCH] make.globals: fix FETCHCOMMAND_SSH and FETCHCOMMAND_SFTP to respect ssh_config port (bug 499198)

2016-05-06 Thread Alexander Berntsen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Ooph. --word-diff pls. - -- Alexander berna...@gentoo.org https://secure.plaimi.net/~alexander -BEGIN PGP SIGNATURE- Version: GnuPG v2 iQIcBAEBCgAGBQJXLJfnAAoJENQqWdRUGk8BfqcP/2W4/PXsI5+NaNN0+q4Gn6M3 ThiDKKlx5AanDNJwIkyeXrq+7IBbMwrPNfQ4yPY

Re: [gentoo-portage-dev] [PATCH] ebuild: Extend helper-in-global-scope ban to all EAPIs

2016-05-06 Thread Alexander Berntsen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Patch looks OK, but this is hardly an area that I'm very knowledgeable about, so if anyone else wants to chime in, that would be great. :) - -- Alexander berna...@gentoo.org https://secure.plaimi.net/~alexander -BEGIN PGP SIGNATURE- Version

[gentoo-portage-dev] [PATCH] make.globals: fix FETCHCOMMAND_SSH and FETCHCOMMAND_SFTP to respect ssh_config port (bug 499198)

2016-05-06 Thread Zac Medico
X-Gentoo-bug: 499198 X-Gentoo-bug-url: https://bugs.gentoo.org/show_bug.cgi?id=499198 --- This is the same as the previous patch, but formatted with --word-diff. cnf/make.globals | 4 ++-- pym/portage/tests/util/test_getconfig.py | 4 ++-- 2 files changed, 4 insertions(+),

Re: [gentoo-portage-dev] [PATCH] ebuild: Extend helper-in-global-scope ban to all EAPIs

2016-05-06 Thread Zac Medico
On 05/06/2016 06:14 AM, Alexander Berntsen wrote: > Patch looks OK, but this is hardly an area that I'm very knowledgeable > about, so if anyone else wants to chime in, that would be great. :) Looks good to me. We could have done this a long time ago, except that it would have broken the illegal m