Re: [gentoo-portage-dev] [PATCH gentoolkit 1/2] eclean: Inline _sort_keys method

2019-12-04 Thread Matt Turner
On Wed, Dec 4, 2019 at 9:17 PM Zac Medico wrote: > > On 12/4/19 6:12 PM, Matt Turner wrote: > > The boilerplate for calling this method was larger than what it actually > > contained. Additionally I think this change will allow the loop to run > > on a generator

[gentoo-portage-dev] [PATCH gentoolkit 1/2] eclean: Inline _sort_keys method

2019-12-04 Thread Matt Turner
The boilerplate for calling this method was larger than what it actually contained. Additionally I think this change will allow the loop to run on a generator rather than a full list. Signed-off-by: Matt Turner --- pym/gentoolkit/eclean/clean.py | 21 ++--- 1 file changed, 6

[gentoo-portage-dev] [PATCH gentoolkit 2/2] eclean: Delete empty directories

2019-12-04 Thread Matt Turner
Closes: https://bugs.gentoo.org/671592 Signed-off-by: Matt Turner --- pym/gentoolkit/eclean/clean.py | 4 1 file changed, 4 insertions(+) diff --git a/pym/gentoolkit/eclean/clean.py b/pym/gentoolkit/eclean/clean.py index b790de0..89300ce 100644 --- a/pym/gentoolkit/eclean/clean.py +++ b

Re: [gentoo-portage-dev] [PATCH gentoolkit 2/2] eclean: Add option to delete binpkgs with changed deps

2020-03-02 Thread Matt Turner
On Sun, Mar 1, 2020 at 10:39 PM Zac Medico wrote: > > On 2/20/20 9:29 PM, Matt Turner wrote: > > @@ -564,7 +577,22 @@ def findPackages( > > > > # Exclude if binpkg exists in the porttree and not --deep > > if not destructive

Re: [gentoo-portage-dev] [PATCH gentoolkit 2/2] eclean: Add option to delete binpkgs with changed deps

2020-03-02 Thread Matt Turner
On Sun, Mar 1, 2020 at 10:32 PM Zac Medico wrote: > > On 2/20/20 9:29 PM, Matt Turner wrote: > > + > > def findPackages( > > options, > > exclude=None, > > @@ -564,7 +577,22 @@ def findPackages( > > > > # Exclude

Re: [gentoo-portage-dev] [PATCH gentoolkit 2/2] eclean: Add option to delete binpkgs with changed deps

2020-03-02 Thread Matt Turner
On Mon, Mar 2, 2020 at 12:40 PM Matt Turner wrote: > > On Sun, Mar 1, 2020 at 10:32 PM Zac Medico wrote: > > > > On 2/20/20 9:29 PM, Matt Turner wrote: > > > + > > > def findPackages( > > > options, > > > exc

[gentoo-portage-dev] Re: [PATCH gentoolkit 1/2] eclean: Rewrite findPackages()

2020-02-20 Thread Matt Turner
On Thu, Feb 20, 2020 at 9:29 PM Matt Turner wrote: > > I found the original code to be nearly incomprehensible. Instead of > populating a dict of potential binpkgs to remove and then removing from > the to-be-removed list, just selectively add to-be-removed packages. > > S

[gentoo-portage-dev] [PATCH gentoolkit 2/2] eclean: Add option to delete binpkgs with changed deps

2020-02-20 Thread Matt Turner
Signed-off-by: Matt Turner --- pym/gentoolkit/eclean/cli.py| 7 ++- pym/gentoolkit/eclean/search.py | 30 +- 2 files changed, 35 insertions(+), 2 deletions(-) diff --git a/pym/gentoolkit/eclean/cli.py b/pym/gentoolkit/eclean/cli.py index 1a99b3e..39aafd3

[gentoo-portage-dev] [PATCH gentoolkit 1/2] eclean: Rewrite findPackages()

2020-02-20 Thread Matt Turner
I found the original code to be nearly incomprehensible. Instead of populating a dict of potential binpkgs to remove and then removing from the to-be-removed list, just selectively add to-be-removed packages. Signed-off-by: Matt Turner --- I switched from tabs to spaces in the process. I can

[gentoo-portage-dev] [PATCH gentoolkit 2/2] imlate: Dynamically calculate column width in report

2020-01-02 Thread Matt Turner
Also print categories on the line with the package name for much simpler consumption by external tools. Signed-off-by: Matt Turner --- pym/gentoolkit/imlate/imlate.py | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/pym/gentoolkit/imlate/imlate.py b/pym

[gentoo-portage-dev] [PATCH gentoolkit 1/2] eclean: Fix typos

2020-01-02 Thread Matt Turner
Signed-off-by: Matt Turner --- pym/gentoolkit/eclean/cli.py| 4 ++-- pym/gentoolkit/eclean/search.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/pym/gentoolkit/eclean/cli.py b/pym/gentoolkit/eclean/cli.py index 1d2f52b..1a99b3e 100644 --- a/pym/gentoolkit/eclean

Re: [gentoo-portage-dev] [PATCH gentoolkit 2/2] imlate: Dynamically calculate column width in report

2020-01-02 Thread Matt Turner
On Thu, Jan 2, 2020 at 12:41 PM Zac Medico wrote: > > On 1/2/20 10:58 AM, Matt Turner wrote: > > Also print categories on the line with the package name for much simpler > > consumption by external tools. > > > > Signed-off-by: Matt Turner > > --- >

Re: [gentoo-portage-dev] [PATCH v2 gentoolkit 2/2] eclean: Add option to delete binpkgs with changed deps

2020-03-11 Thread Matt Turner
On Wed, Mar 11, 2020 at 9:36 PM Matt Turner wrote: > > On Wed, Mar 11, 2020 at 9:31 PM Zac Medico wrote: > > > > On 3/6/20 10:11 PM, Matt Turner wrote: > > > Signed-off-by: Matt Turner > > > --- > > > pym/gentoolkit/eclean/cli.py| 7 ++

Re: [gentoo-portage-dev] [PATCH v2 gentoolkit 2/2] eclean: Add option to delete binpkgs with changed deps

2020-03-11 Thread Matt Turner
On Wed, Mar 11, 2020 at 10:23 PM Zac Medico wrote: > The coupling with --destructive logic complicates matters. It raises the > question, why isn't --time-limit logic also coupled with --destructive > logic? I think "in order to preserve the status quo" is a reasonable > answer to this question.

Re: [gentoo-portage-dev] [PATCH v2 gentoolkit 2/2] eclean: Add option to delete binpkgs with changed deps

2020-03-11 Thread Matt Turner
On Wed, Mar 11, 2020 at 9:31 PM Zac Medico wrote: > > On 3/6/20 10:11 PM, Matt Turner wrote: > > Signed-off-by: Matt Turner > > --- > > pym/gentoolkit/eclean/cli.py| 7 ++- > > pym/gentoolkit/eclean/search.py | 24 +++- > >

Re: [gentoo-portage-dev] [PATCH gentoolkit 2/2] eclean: Add option to delete binpkgs with changed deps

2020-03-06 Thread Matt Turner
On Mon, Mar 2, 2020 at 9:15 PM Zac Medico wrote: > > On 3/2/20 1:11 PM, Matt Turner wrote: > > On Sun, Mar 1, 2020 at 10:39 PM Zac Medico wrote: > >> > >> On 2/20/20 9:29 PM, Matt Turner wrote: > >>> @@ -564,7 +577,22 @@ def findPackages( >

[gentoo-portage-dev] [PATCH v2 gentoolkit 2/2] eclean: Add option to delete binpkgs with changed deps

2020-03-06 Thread Matt Turner
Signed-off-by: Matt Turner --- pym/gentoolkit/eclean/cli.py| 7 ++- pym/gentoolkit/eclean/search.py | 24 +++- 2 files changed, 29 insertions(+), 2 deletions(-) diff --git a/pym/gentoolkit/eclean/cli.py b/pym/gentoolkit/eclean/cli.py index 1a99b3e..39aafd3 100644

[gentoo-portage-dev] [PATCH v2 gentoolkit 1/2] eclean: Rewrite findPackages()

2020-03-06 Thread Matt Turner
I found the original code to be nearly incomprehensible. Instead of populating a dict of potential binpkgs to remove and then removing from the to-be-removed list, just selectively add to-be-removed packages. Signed-off-by: Matt Turner --- pym/gentoolkit/eclean/search.py | 113

Re: [gentoo-portage-dev] [PATCH v2 gentoolkit 2/2] eclean: Add option to delete binpkgs with changed deps

2020-03-11 Thread Matt Turner
On Tue, Mar 10, 2020 at 8:30 PM Zac Medico wrote: > > On 3/6/20 10:11 PM, Matt Turner wrote: > > +def _deps_equal(deps_a, deps_b, eapi, uselist=None): > > + """Compare two dependency lists given a set of USE flags""" > > + i

[gentoo-portage-dev] [PATCH] Change BINPKG_COMPRESS default from bzip2 to xz

2020-04-26 Thread Matt Turner
Bug: https://bugs.gentoo.org/715108 Signed-off-by: Matt Turner --- Strawman patch. Bikeshed away. bin/quickpkg | 2 +- lib/portage/package/ebuild/doebuild.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/bin/quickpkg b/bin/quickpkg index

[gentoo-portage-dev] [PATCH] man/make.conf.5: Mention eclean in PKGDIR section

2020-04-26 Thread Matt Turner
And remove obsolete text from binpkg-multi-instance. I believe this was obsolete even before my gentoolkit patches that add the --changed-deps flag to eclean packages. Signed-off-by: Matt Turner --- man/make.conf.5 | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/man

Re: [gentoo-portage-dev] [PATCH] Change BINPKG_COMPRESS default from bzip2 to xz

2020-04-26 Thread Matt Turner
On Sun, Apr 26, 2020 at 12:29 PM Michał Górny wrote: > > On Sun, 2020-04-26 at 09:55 -0700, Matt Turner wrote: > > Bug: https://bugs.gentoo.org/715108 > > Signed-off-by: Matt Turner > > --- > > Strawman patch. Bikeshed away. > > > > xz is generally slow

Re: [gentoo-portage-dev] [PATCH 0/2] emerge: Add short -l option for --load-average (bug 699256)

2020-08-15 Thread Matt Turner
On Sat, Aug 15, 2020 at 12:27 PM Zac Medico wrote: > > Add a short -l option for --load-average just like make(1) has. That's awesome, thank you. That'll make some catalyst work easier for me.