[gentoo-portage-dev] Fix Misc. Bash Errors in phase-helpers.sh.

2018-02-03 Thread R0b0t1
multiple tests. The other changes are almost stylistic. I made a PR (https://github.com/gentoo/portage/pull/251) before I remembered that that repo was a mirror. Cheers, R0b0t1 From f93e8e1b1e8df555fe90d2efdb68afa314d0719e Mon Sep 17 00:00:00 2001 From: Sid Spry Date: Sat, 3 Feb 2018 23:44:56

[gentoo-portage-dev] Fix all misc. bash errors.

2018-02-04 Thread R0b0t1
teresting was: eval "$x=(\"\${$x[@]}\" ${QA_PREBUILT//\*/.*})" Which looks like a bad array expansion ("$x[@]"). Cheers, R0b0t1 --- bin/ebuild-helpers/newins | 2 +- bin/ebuild.sh | 2 +- bin/etc-update| 6 +++--- bin/isolated-functions.sh

Re: [gentoo-portage-dev] Fix all misc. bash errors.

2018-02-05 Thread R0b0t1
On Sun, Feb 4, 2018 at 10:45 PM, Zac Medico wrote: > On 02/04/2018 07:22 PM, R0b0t1 wrote: >> This is everything that shellcheck reported as an error. They are not >> as serious as the globbing issue, but it would be a good idea to >> change them. They are general

Re: [gentoo-portage-dev] Fix all misc. bash errors.

2018-02-05 Thread R0b0t1
On Mon, Feb 5, 2018 at 8:33 PM, R0b0t1 wrote: > On Sun, Feb 4, 2018 at 10:45 PM, Zac Medico wrote: >> On 02/04/2018 07:22 PM, R0b0t1 wrote: >>> This is everything that shellcheck reported as an error. They are not >>> as serious as the globbing issue, but it would b

Re: [gentoo-portage-dev] Fix all misc. bash errors.

2018-02-07 Thread R0b0t1
On Wed, Feb 7, 2018 at 1:41 AM, Michał Górny wrote: > W dniu pon, 05.02.2018 o godzinie 20∶33 -0600, użytkownik R0b0t1 > napisał: >> On Sun, Feb 4, 2018 at 10:45 PM, Zac Medico wrote: >> > On 02/04/2018 07:22 PM, R0b0t1 wrote: >> > > This is everything that shel