Re: [gentoo-portage-dev] [PATCH] news.py: Check only for major version when parsing

2016-05-18 Thread Alexander Berntsen 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512

On 18/05/16 17:46, Zac Medico wrote:
> not fnmatch.fnmatch(format_match.group(1), '1.*')):
Wait, why "not"?

- -- 
Alexander
berna...@gentoo.org
https://secure.plaimi.net/~alexander
-BEGIN PGP SIGNATURE-
Version: GnuPG v2

iQIcBAEBCgAGBQJXPKCxAAoJENQqWdRUGk8B7QAP/ixWgI2RU1CBXNLe+77mgxKk
rVtetbPmXyjiWgrkQvayLOVHF5JO4sh7PiH4Qpo75VhFKr48/GuIfYzt3q6b8gNn
GwP0fI0zc/fBoQYaHXI/qjyp+uCcEQAhT2yuvRFat7wRPTgSJKcbk/vsA6Eoof4c
rin3uWiWI5P+vNI7Kbmv7NNFshQ9Ak4J80AZmc+h/H0asj7Va7s/FyhlnXciL4Xh
H4H8SklefZoN+m8gPo90o6ny5PLIlDAtrdsESKXtKqKFX4OFyjkfRn3I7M+Gplki
+zrxDKGK2fYNMsgECS003cGEtnlkF2d9DTUAakCQJadKLPZXJ8kZnissBcmIqwyg
dH+1IhFUHAeBghEfan86x9SEtJ0HIEYEX/zHrknCZDLRtk5V8grlyWjA3bRYtfka
CbX6J4F0hgDPao4WHkUYp6I6NaDJTA9XwyNkX0E+GObCu9GvvdMy87DOFVVkEua9
Hlq6XAyTnMRZ3doh8eS2enDMul1qlng742BQ8D9egc49GxSl6eIZwELDS0QsTkQN
I+KNIB3ktNnxhh4FX+Gp4HPXEtsXNbXzqfNp6AbYcWh/lbH5jVZOYwuU+sJ/Ky/j
76hdj9BmNsncsPvmxxslBjJHq8SKIs3RKs+9HukFN/+zbSpGvkhi5BQQ3Tk+tPZK
Ju6X2kT2Hu3s77Wt6XjX
=t647
-END PGP SIGNATURE-

Re: [gentoo-portage-dev] [PATCH] news.py: Check only for major version when parsing

2016-05-18 Thread Alexander Berntsen 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512

On 18/05/16 17:46, Zac Medico wrote:
> if (format_match is not None and not
> fnmatch.fnmatch(format_match.group(1), '1.*')):
Yes! Sorry! I had made that change, but then forgotten to stage it. So
sorry. It's been hell of a day, so it just slipped past me. I'll get
right to it.

- -- 
Alexander
berna...@gentoo.org
https://secure.plaimi.net/~alexander
-BEGIN PGP SIGNATURE-
Version: GnuPG v2

iQIcBAEBCgAGBQJXPJ7lAAoJENQqWdRUGk8BK5UQAIjkJMxmoBi2uKGWHNpZ6gvg
X2km6wtokpowTtrTNVRD5zjtJeyhKPa/jkp5EVoka6GbW8Ap/9ykUSR36xxscQ5R
HxWnpP6OPrPS59wpXU+gTRLOwEhLE9gP1WEQFHPCnPwmIasYXZl4BXK/IOU3rblc
PymEa+VvTU2Kg0EdLsnqQ4rHvkBngwykByC64zM3eL3ZoJoO8tmZ8cRByObCYWk/
SJkLp6F/WdWJSmwldS/e+HhgAn0Y7DEKpv3NYpKT3osv+ga4CXaxalToNy+pmwIj
kAC7EqMREBEOAumcitTPKxKtUZhkxm/SJC/+e0BWAvOAWMcP9+pxRmMwTx8wrgym
6zN53g+MFSqYMxwm5Xvy+vIBflfXBiRYFNxs/hGfDLCh5270pHnvYH4V80lS8wQX
InobYnpuwQcvJWN5CiT0kY8fYTgfCE28AIBgPSHO62+Fbmc60v0Fbh7X8KDv1aI7
TPKCldsFuIXj5X3PefGM8/aUq4DE94slGtNSiVrl1c+KKfKRCY6g6XzjYNm2m1i6
cwXldoofl973bNAyV9m3ACntHQXV/Q+/h4imC2lS08Yhb6s8lmsSrozEQqoYbgPN
0c1aFF+maNjDZKH0oDDXhLW2JeKScEan6lyotppiWKImJhqgq+oWVtg3asBx426k
CKOQJdfbZtI0ICBLL5eY
=1ZKx
-END PGP SIGNATURE-

[gentoo-portage-dev] [PATCH] news.py: Check only for major version when parsing

2016-05-18 Thread Alexander Berntsen 
Only check the major version of news items, as GLEP 42 specifies an
upgrade path for them. Future revisions to news item formats may yield
minor number increments. GLEP 42 further ensures that only
forwards-compatible changes may incur, as incompatible changes demand a
major version increment.

Suggested-by:  Ulrich Müller  
Signed-off-by: Alexander Berntsen 
---
 pym/portage/news.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pym/portage/news.py b/pym/portage/news.py
index 784ba70..f52d96e 100644
--- a/pym/portage/news.py
+++ b/pym/portage/news.py
@@ -270,7 +270,7 @@ class NewsItem(object):
# Optimization to ignore regex matchines on lines that
# will never match
format_match = _formatRE.match(line)
-   if format_match is not None and format_match.group(1) 
!= '1.0':
+   if format_match is not None and format_match.group(1) 
!= '1.*':
invalids.append((i + 1, line.rstrip('\n')))
break
if not line.startswith('D'):
-- 
2.7.3