Complain only about deprecated eclasses that are inherited directly.
Checking indirectly inherited eclasses is pointless since the ebuild
maintainer can't really do anything about it --- it is up to
the maintainer of one of the directly inherited eclasses.
---
pym/repoman/checks.py | 16 ----------------
1 file changed, 16 deletions(-)
diff --git a/pym/repoman/checks.py b/pym/repoman/checks.py
index abb9545..5f37648 100644
--- a/pym/repoman/checks.py
+++ b/pym/repoman/checks.py
@@ -395,11 +395,8 @@ class InheritDeprecated(LineCheck):
def new(self, pkg):
self._errors = []
- self._indirect_deprecated = set(eclass for eclass in \
- self.deprecated_classes if eclass in pkg.inherited)
def check(self, num, line):
-
direct_inherits = None
m = self._inherit_re.match(line)
if m is not None:
@@ -415,11 +412,9 @@ class InheritDeprecated(LineCheck):
if replacement is None:
pass
elif replacement is False:
- self._indirect_deprecated.discard(eclass)
self._errors.append("please migrate from " + \
"'%s' (no replacement) on line: %d" %
(eclass, num + 1))
else:
- self._indirect_deprecated.discard(eclass)
self._errors.append("please migrate from " + \
"'%s' to '%s' on line: %d" % \
(eclass, replacement, num + 1))
@@ -429,17 +424,6 @@ class InheritDeprecated(LineCheck):
yield error
del self._errors
- for eclass in self._indirect_deprecated:
- replacement = self.deprecated_classes[eclass]
- if replacement is False:
- yield "please migrate from indirect " + \
- "inherit of '%s' (no replacement)" %
(eclass,)
- else:
- yield "please migrate from indirect " + \
- "inherit of '%s' to '%s'" % \
- (eclass, replacement)
- del self._indirect_deprecated
-
class InheritEclass(LineCheck):
"""
Base class for checking for missing inherits, as well as excess
inherits.
--
2.1.0
