Re: [gentoo-portage-dev] Re: [PATCH v2] Change how the tmp file for the commit msg is made (bug 571546)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On Mon, 23 May 2016 12:43:04 +0200 Alexander Berntsen wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > I see you have incorporated Zac's feedback by using shutil. You have > also incorporated my feedback on the commit message. I forgot to say > that the message body should also begin in the imperative mood, so it > should be "Change" not "Changes". But that's OK, we can just change > this when we merge it. My bad. > > The patch still looks OK to my eyes. I will leave it to Brian to ack, > as repoman has been his baby these past months. (Brian, I can merge it > if you don't have the time, but please give an ack.) > - -- > Alexander > berna...@gentoo.org > https://secure.plaimi.net/~alexander > -BEGIN PGP SIGNATURE- > Version: GnuPG v2 > > iQIcBAEBCgAGBQJXQt64AAoJENQqWdRUGk8BksQP/iV301h2bP32hHeAh0e+YUHH > NmUvwx1KSAnAjaL28rTEE8LzJcy+QDTdwhW9Y9x7gUD0fWeUuQpMXEnIQ7DIVmm/ > XfNI8M9bey90VLa8VNzIkfpHqeb5asvkHSLlyVVCb/BcE/wR23peRdW4F9LAhrAs > 0Mdz+g09Bjb5SawiTyaNig+YSid8MDWTDI+6oskB8NAhyaDqaUKGk/HfGqAG95FW > lbXIBE4dIQ2jFdzyn+3/rXWXBVCuXL1OufQPSiIFwfsU4j957SRo/cYlDqXyyQXD > mXXju2fU3cEk16Po+7v9wNp77xu2HdML7jgO75HdSDN5eDMJ3gyFlrlLw1Ztw9OA > v4+IXcbgGEGguN4Tz+DuY1+htGRnjBR5C2dj6y6rZU9HbIMTzJSxI/rQQUsQJ53j > Nd6++GJXqpskDhd+Zx1Gmhj5yV/h7Nc/YDUsT6CTsLNOzVJUy6acyhWqJRt46MAs > 9nw1c9xqoGLhCiWvAK5PZOz4/cfEUtEawUrQg4wtoPap05qzMx8fsk3rX9J7ifrq > rQlBVxwGQqjN9ykzDl2IkY8/W9sx8Nhe5/M5rmUCsk0KUzhcrkQNCOHdzSSU2jSM > Yimj4y+gBnizHIVn2+sAZ4vosTXic/zVKi5meYgSM4pBRAwD4GJgQ5vV//cWTTZl > 6QTa+hD/NQZAQd14COhc > =9N4L > -END PGP SIGNATURE- > Sorry, merged finally - -- Brian Dolbec -BEGIN PGP SIGNATURE- Version: GnuPG v2 iQKTBAEBCgB9FiEEpdfHTggcxw20pKr1+70IcnWCDtgFAljJu0JfFIAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEE1 RDdDNzRFMDgxQ0M3MERCNEE0QUFGNUZCQkQwODcyNzU4MjBFRDgACgkQ+70IcnWC DtibPg/+IyqLtruXwdmDMuUyr+CJtnPlF2k6WD9JK5xp8j8yqAnZ3VhmvWQeLzL0 Gs0PkcquVuNKie6vVA+fgoyS73ji1KGX8c5ZO0eE5zU4tGEOAV3zL15crJ3hZvSl W4vlQlPJgGigld4ztb15nUwYn+O0w+K03uabYhSORBCHRvuDsKTB23+KYJaM9SPC upM4xA+ThQCdF4Vc8d1MiKz12Zmyfpkpmq5h2wHPGfkq5JEf5Hct879l278lD9cl TFrH6BXKKF92isr1bQx6u7Fmap6CT5PHmrKyipDPnI5GEqRQY2j4BuG67DFvQdBp /OwfOKZWOC+lRkGUFVV7WT0EBWBdGTsEe4KWE8pv8wWYrZi8xxqzJPhUcbxyS+uB 42Ry1OM0XkPd2pI+S/yVAJR+QVQDspvRrkOxN850Sf1aJeyCh8h5zCpb/oY0Bhvg siKdjoHd7/xHp0CATiMdlfYQsZJNhRs/f2ks4S+LH0MZr4VabclIG9SN19sHWR00 +TC6mvwCFoQpxDS+VNby4iWRL2mnLgCr3FYCVapbA6Mypr/I2nvfBwQwb3OYlz39 VWD/yDN18uKYk12Gm6VXRQaJImPr4H4+gfXp1zd/FdBkIV4oKpVo03Xp2qcIIzR9 fbI+hUbMVGlcthS4hbxQHJqPCp1PXD/dAoFL/f7yNK/AJiM85ic= =mt0p -END PGP SIGNATURE-
[gentoo-portage-dev] Re: [PATCH v2] Change how the tmp file for the commit msg is made (bug 571546)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 I see you have incorporated Zac's feedback by using shutil. You have also incorporated my feedback on the commit message. I forgot to say that the message body should also begin in the imperative mood, so it should be "Change" not "Changes". But that's OK, we can just change this when we merge it. My bad. The patch still looks OK to my eyes. I will leave it to Brian to ack, as repoman has been his baby these past months. (Brian, I can merge it if you don't have the time, but please give an ack.) - -- Alexander berna...@gentoo.org https://secure.plaimi.net/~alexander -BEGIN PGP SIGNATURE- Version: GnuPG v2 iQIcBAEBCgAGBQJXQt64AAoJENQqWdRUGk8BksQP/iV301h2bP32hHeAh0e+YUHH NmUvwx1KSAnAjaL28rTEE8LzJcy+QDTdwhW9Y9x7gUD0fWeUuQpMXEnIQ7DIVmm/ XfNI8M9bey90VLa8VNzIkfpHqeb5asvkHSLlyVVCb/BcE/wR23peRdW4F9LAhrAs 0Mdz+g09Bjb5SawiTyaNig+YSid8MDWTDI+6oskB8NAhyaDqaUKGk/HfGqAG95FW lbXIBE4dIQ2jFdzyn+3/rXWXBVCuXL1OufQPSiIFwfsU4j957SRo/cYlDqXyyQXD mXXju2fU3cEk16Po+7v9wNp77xu2HdML7jgO75HdSDN5eDMJ3gyFlrlLw1Ztw9OA v4+IXcbgGEGguN4Tz+DuY1+htGRnjBR5C2dj6y6rZU9HbIMTzJSxI/rQQUsQJ53j Nd6++GJXqpskDhd+Zx1Gmhj5yV/h7Nc/YDUsT6CTsLNOzVJUy6acyhWqJRt46MAs 9nw1c9xqoGLhCiWvAK5PZOz4/cfEUtEawUrQg4wtoPap05qzMx8fsk3rX9J7ifrq rQlBVxwGQqjN9ykzDl2IkY8/W9sx8Nhe5/M5rmUCsk0KUzhcrkQNCOHdzSSU2jSM Yimj4y+gBnizHIVn2+sAZ4vosTXic/zVKi5meYgSM4pBRAwD4GJgQ5vV//cWTTZl 6QTa+hD/NQZAQd14COhc =9N4L -END PGP SIGNATURE-
[gentoo-portage-dev] Re: [PATCH v2] Change how the tmp file for the commit msg is made (bug 571546)
On 05/18/2016 11:57 AM, Doug Goldstein wrote: > On 5/18/16 11:38 AM, Zac Medico wrote: >> On Tue, May 17, 2016 at 11:43 PM, Alexander Berntsen >> wrote: >>> -BEGIN PGP SIGNED MESSAGE- >>> Hash: SHA512 >>> >>> On 17/05/16 15:36, Doug Goldstein wrote: ping? I believe I covered all the review items but I see this is not in master yet. Is there anything further you need me to do? >>> It seems you are replying to a thread with a second version of your >>> patch. I don't have the initial email to this thread. I don't know >>> what fucked up, or where. Could you resend the patch? Sorry about this. >> >> This continues a thread that originally started on the dev-portage >> alias, but I don't see a mail PATCH v2 anywhere either. >> >> Thanks, >> Zac >> > > I sent it to gentoo-portage-dev@lists.gentoo.org as requested. I can > resend it. > It was probably during a certain window of time a couple months back when no mails were reaching the list. -- Thanks, Zac
[gentoo-portage-dev] Re: [PATCH v2] Change how the tmp file for the commit msg is made (bug 571546)
On Tue, May 17, 2016 at 11:43 PM, Alexander Berntsen wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > On 17/05/16 15:36, Doug Goldstein wrote: >> ping? I believe I covered all the review items but I see this is >> not in master yet. Is there anything further you need me to do? > It seems you are replying to a thread with a second version of your > patch. I don't have the initial email to this thread. I don't know > what fucked up, or where. Could you resend the patch? Sorry about this. This continues a thread that originally started on the dev-portage alias, but I don't see a mail PATCH v2 anywhere either. Thanks, Zac
[gentoo-portage-dev] Re: [PATCH v2] Change how the tmp file for the commit msg is made (bug 571546)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 17/05/16 15:36, Doug Goldstein wrote: > ping? I believe I covered all the review items but I see this is > not in master yet. Is there anything further you need me to do? It seems you are replying to a thread with a second version of your patch. I don't have the initial email to this thread. I don't know what fucked up, or where. Could you resend the patch? Sorry about this. - -- Alexander berna...@gentoo.org https://secure.plaimi.net/~alexander -BEGIN PGP SIGNATURE- Version: GnuPG v2 iQIcBAEBCgAGBQJXPA8LAAoJENQqWdRUGk8BuFkP/0sRbHDfXOONLKbDlBsgea3H O780Q9zqj/QZD0ZrSFrZ1fw6pISzGs0vdKs+E5BgUfMJm4lQAzzFMv/D2/1X5pTp 6VZoROqNFVlvgh9WGeZFi/8/BYJL34VxtTggJH/TuNauVBdUt8NG6lGnhVbUdWiR s8vIA7GIVubwR7Wrx1a0e/P5SpNUQ3gTL5IhdRiUei4oPXVz5cjTxA3vYRoC+9zu KedlJG43x06OSiixXFP0Ye/R1ctWA8w7d4pdRHrbxZNaXUTxIu6C4FzhQmTiAyvi pJpbqdXRG0pvgsfbpHcSpOxhWcn5JrkvJ8TiVepOKV7ZOzt/v5t34+gHVAGKQ7TD rgnRYUnVf4kGfSPWhpGDfBQFmz2tVatTZLXVEI0R6Y2x7Yw95pFreRAUZQG2s6Za udMnEgKWs0z9hwvnYizNIWvM9zJCCfMFK7DeVFt48KXZEmI2UjDgbeSS53SsqwfO 2AcW9Z2kJ1wbLi0/AiATS5V9t/43j9zD1wy7COqSGozweRJa9lT9v9dwVfcTDNYX +GabcpxZ408sJLAY7Cpnb8+Tgzrp1eCRAIKnxMGzki88hIPDvtfyq6uJ9soB7ls4 cuGoFHDKFQdzK6GvUclOCZ7iY1TZivEyMehvoyxdUSxa7APP6OW1oguz3FmExDVc FZKez232lbT+eJ/iGy0o =ZRb+ -END PGP SIGNATURE-
