Re: [gentoo-portage-dev] [PATCH] global_event_loop: use asyncio event loop (bug 654390)

2018-05-08 Thread Zac Medico 
On 05/08/2018 08:55 AM, Alec Warner wrote:
> lgtm.
> 
> -A
> 
> On Tue, May 8, 2018 at 11:43 AM, Brian Dolbec  > wrote:
> 
> On Mon,  7 May 2018 03:18:32 -0700
> Zac Medico > wrote:
> 
> > +             # This attribute it used by _wrap_loop to detect if
> > the
> 
> typo, s/it/is
> 
> this asynio stuff is mostly beyond my familiarity... but all looks ok,
> and I know you ran the tests on it...
> 
> should be good to merge unless anyone else objects...
> 
> -- 
> Brian Dolbec 

Thanks, merged:

https://gitweb.gentoo.org/proj/portage.git/commit/?id=96cc073263910e7c1b0f48cc08a4db4b56ffe408
-- 
Thanks,
Zac



signature.asc
Description: OpenPGP digital signature

Re: [gentoo-portage-dev] [PATCH] global_event_loop: use asyncio event loop (bug 654390)

2018-05-08 Thread Alec Warner 
lgtm.

-A

On Tue, May 8, 2018 at 11:43 AM, Brian Dolbec  wrote:

> On Mon,  7 May 2018 03:18:32 -0700
> Zac Medico  wrote:
>
> > + # This attribute it used by _wrap_loop to detect if
> > the
>
> typo, s/it/is
>
> this asynio stuff is mostly beyond my familiarity... but all looks ok,
> and I know you ran the tests on it...
>
> should be good to merge unless anyone else objects...
>
> --
> Brian Dolbec 
>
>
>

Re: [gentoo-portage-dev] [PATCH] global_event_loop: use asyncio event loop (bug 654390)

2018-05-08 Thread Brian Dolbec 
On Mon,  7 May 2018 03:18:32 -0700
Zac Medico  wrote:

> + # This attribute it used by _wrap_loop to detect if
> the
 
typo, s/it/is

this asynio stuff is mostly beyond my familiarity... but all looks ok,
and I know you ran the tests on it... 

should be good to merge unless anyone else objects...

-- 
Brian Dolbec