Re: [gentoo-portage-dev] [PATCH] repoman: Fix versioning system
On Mon, 5 Dec 2016 13:10:38 -0800 Zac Medicowrote: > On 12/05/2016 12:32 PM, Brian Dolbec wrote: > > On Mon, 5 Dec 2016 11:42:10 -0800 > > Brian Dolbec wrote: > > > >> From 1586f1a25c41fb6036a24b47cfa58e3e818b8a58 Mon Sep 17 00:00:00 > >> 2001 From: Brian Dolbec > >> Date: Mon, 5 Dec 2016 11:27:15 -0800 > >> Subject: [PATCH] repoman: Fix versioning system > >> > >> Repoman had been showing the portage version. Which was the same > >> for the last release. Copy the live versions code from portage, > >> Modify as needed to get the correct tag info. Add portage version > >> to --version output. --- > >> repoman/pym/repoman/__init__.py | 70 > >> + > > > > For some reason, without the single quoting the match string, "git > > describe --match portage-*" would fail while "git describe --match > > repoman-*" would without the single quotes. > > > > Anyway, I updated the repoman patch to single quote it. > > Yeah, it definitely needs to be quoted, in order to prevent shell > expansion. Apparently you had a file or directory patching portage-* > in your working directory. merged -- Brian Dolbec
Re: [gentoo-portage-dev] [PATCH] repoman: Fix versioning system
On 12/05/2016 12:32 PM, Brian Dolbec wrote: > On Mon, 5 Dec 2016 11:42:10 -0800 > Brian Dolbecwrote: > >> From 1586f1a25c41fb6036a24b47cfa58e3e818b8a58 Mon Sep 17 00:00:00 2001 >> From: Brian Dolbec >> Date: Mon, 5 Dec 2016 11:27:15 -0800 >> Subject: [PATCH] repoman: Fix versioning system >> >> Repoman had been showing the portage version. Which was the same for >> the last release. Copy the live versions code from portage, Modify as >> needed to get the correct tag info. Add portage version to --version >> output. --- >> repoman/pym/repoman/__init__.py | 70 >> + > > For some reason, without the single quoting the match string, "git describe > --match portage-*" > would fail while "git describe --match repoman-*" would without the single > quotes. > > Anyway, I updated the repoman patch to single quote it. Yeah, it definitely needs to be quoted, in order to prevent shell expansion. Apparently you had a file or directory patching portage-* in your working directory. -- Thanks, Zac
Re: [gentoo-portage-dev] [PATCH] repoman: Fix versioning system
On Mon, 5 Dec 2016 11:42:10 -0800 Brian Dolbecwrote: > From 1586f1a25c41fb6036a24b47cfa58e3e818b8a58 Mon Sep 17 00:00:00 2001 > From: Brian Dolbec > Date: Mon, 5 Dec 2016 11:27:15 -0800 > Subject: [PATCH] repoman: Fix versioning system > > Repoman had been showing the portage version. Which was the same for > the last release. Copy the live versions code from portage, Modify as > needed to get the correct tag info. Add portage version to --version > output. --- > repoman/pym/repoman/__init__.py | 70 > + For some reason, without the single quoting the match string, "git describe --match portage-*" would fail while "git describe --match repoman-*" would without the single quotes. Anyway, I updated the repoman patch to single quote it. -- Brian Dolbec