Re: [gentoo-portage-dev] [PATCH 0/4] Output rewrite for better clarify and greppability

2021-10-03 Thread Michał Górny
On Tue, 2021-09-28 at 16:20 +0200, Michał Górny wrote:
> Hi,
> 
> Ok, so it's more major than I originally intended but I think it's
> a good direction (once you get used to it). Roughly:
> 

I'm retracting this in favor of whatever gentoo-dev participants come up
with.

-- 
Best regards,
Michał Górny





Re: [gentoo-portage-dev] [PATCH 0/4] Output rewrite for better clarify and greppability

2021-09-28 Thread Michał Górny
On Tue, 2021-09-28 at 11:28 -0400, Mike Gilbert wrote:
> On Tue, Sep 28, 2021 at 10:20 AM Michał Górny  wrote:
> > 
> > Hi,
> > 
> > Ok, so it's more major than I originally intended but I think it's
> > a good direction (once you get used to it). Roughly:
> > 
> > 1. All bash color vars are now prefixed with `PORTAGE_COLOR_` to avoid
> >accidental collisions with ebuild vars (e.g. ebuild setting
> >`GOOD=foo` broke `elog` before).
> > 2. There are specific color vars for all kinds of output functions,
> >and now `einfo` messages use distinct color (dark green) from `elog`,
> >and `eqawarn` (brown) from `ewarn`.
> > 3. Messages are now prefixed by their kind, making it possible to
> >distinguish them without colors and grep for specific kind of logs:
> >- `[--]` for einfo & ebegin
> >- `[II]` for elog
> >- `[WW]` for ewarn
> >- `[QA]` for eqawarn
> >- `[EE]` for eerror
> > 4. Finally, I've replaced most of `>>>` and `!!!` in Portage output with
> >four `` and `` to align the output again.
> 
> I like it.
> 
> Maybe add a reference to this bug? https://bugs.gentoo.org/728046
> 

Oh right, I also need to work on removing redundant 'QA Notice:'
thingies.

-- 
Best regards,
Michał Górny





Re: [gentoo-portage-dev] [PATCH 0/4] Output rewrite for better clarify and greppability

2021-09-28 Thread Mike Gilbert
On Tue, Sep 28, 2021 at 10:20 AM Michał Górny  wrote:
>
> Hi,
>
> Ok, so it's more major than I originally intended but I think it's
> a good direction (once you get used to it). Roughly:
>
> 1. All bash color vars are now prefixed with `PORTAGE_COLOR_` to avoid
>accidental collisions with ebuild vars (e.g. ebuild setting
>`GOOD=foo` broke `elog` before).
> 2. There are specific color vars for all kinds of output functions,
>and now `einfo` messages use distinct color (dark green) from `elog`,
>and `eqawarn` (brown) from `ewarn`.
> 3. Messages are now prefixed by their kind, making it possible to
>distinguish them without colors and grep for specific kind of logs:
>- `[--]` for einfo & ebegin
>- `[II]` for elog
>- `[WW]` for ewarn
>- `[QA]` for eqawarn
>- `[EE]` for eerror
> 4. Finally, I've replaced most of `>>>` and `!!!` in Portage output with
>four `` and `` to align the output again.

I like it.

Maybe add a reference to this bug? https://bugs.gentoo.org/728046