Re: [gentoo-portage-dev] [PATCH 2/2] ebuild.sh: Update QA notice in inherit()

2021-08-29 Thread Michał Górny 
On Mon, 2021-08-30 at 00:47 +0200, Ulrich Mueller wrote:
> > > > > > On Sun, 29 Aug 2021, Michał Górny wrote:
> 
> > On Sun, 2021-08-29 at 22:06 +0200, Ulrich Müller wrote:
> > > - eqawarn "For compatibility with
> > > <=portage-2.1.6.7, only call EXPORT_FUNCTIONS"
> > > - eqawarn "after inherit(s)."
> > > + eqawarn "For compatibility with PMS, only
> > > call EXPORT_FUNCTIONS after inherit(s)."
> 
> > Could you add a sentence that the current Portage behavior is going
> > to
> > change in the future?
> 
> Sure, but do we actually know that?

That's the plan today, can't be 100% sure it'll happen.  You can say
'can change' if you think it's better -- but people need some motivation
or they're just going to ignore it as 'another PMS noise'.

Alternatively, we could mention that pkgcore is broken by this.
My point is mostly to say 'yes, this breaks stuff for users today, it's
not just some theory'.

-- 
Best regards,
Michał Górny

Re: [gentoo-portage-dev] [PATCH 2/2] ebuild.sh: Update QA notice in inherit()

2021-08-29 Thread Ulrich Mueller 
> On Sun, 29 Aug 2021, Michał Górny wrote:

> On Sun, 2021-08-29 at 22:06 +0200, Ulrich Müller wrote:
>> -eqawarn "For compatibility with <=portage-2.1.6.7, only 
>> call EXPORT_FUNCTIONS"
>> -eqawarn "after inherit(s)."
>> +eqawarn "For compatibility with PMS, only call 
>> EXPORT_FUNCTIONS after inherit(s)."

> Could you add a sentence that the current Portage behavior is going to
> change in the future?

Sure, but do we actually know that?


signature.asc
Description: PGP signature

Re: [gentoo-portage-dev] [PATCH 2/2] ebuild.sh: Update QA notice in inherit()

2021-08-29 Thread Michał Górny 
On Sun, 2021-08-29 at 22:06 +0200, Ulrich Müller wrote:
> Bug: https://bugs.gentoo.org/399039
> Signed-off-by: Ulrich Müller 
> ---
>  bin/ebuild.sh | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/bin/ebuild.sh b/bin/ebuild.sh
> index 1bca2c965..f5f3d9eec 100755
> --- a/bin/ebuild.sh
> +++ b/bin/ebuild.sh
> @@ -248,8 +248,7 @@ inherit() {
>   # previous inherit call in the call stack.
>   if [[ -n ${ECLASS} && -n ${!__export_funcs_var} ]] ; then
>   eqawarn "QA Notice: EXPORT_FUNCTIONS is called before 
> inherit in ${ECLASS}.eclass."
> - eqawarn "For compatibility with <=portage-2.1.6.7, only 
> call EXPORT_FUNCTIONS"
> - eqawarn "after inherit(s)."
> + eqawarn "For compatibility with PMS, only call 
> EXPORT_FUNCTIONS after inherit(s)."
>   fi
>   fi
> 

Could you add a sentence that the current Portage behavior is going to
change in the future?


-- 
Best regards,
Michał Górny