Re: [gentoo-portage-dev] [PATCH v3 1/2] bin/install-qa-check.d: add new 90bad-bin-owner QA check.
On 08/07/2018 10:44 AM, Michael Orlitzky wrote:
> On 08/07/2018 01:34 PM, Zac Medico wrote:
>>
>> Why not use ${ED%/} instead of ${D%/} here, so that the output is the
>> same regardless of ${EPREFIX}?
>>
>
> We want to show where the executable was actually installed, and
> generally that includes EPREFIX. For example, I'd want to see
>
> /var/tmp/whatever/.../root/prefix/usr/bin/foo
>
> reported as
>
> /root/prefix/usr/bin/foo
>
> rather than
>
> /usr/bin/foo
>
> Of course, these checks are now skipped on prefix systems anyway, so
> it's a bit of a moot point. But I think it's more future-proof to strip
> only the $D.
Sounds good. Thanks! Merged:
https://gitweb.gentoo.org/proj/portage.git/commit/?id=807ac3d9d6eecead73f59d399b30559e5c731587
--
Thanks,
Zac
signature.asc
Description: OpenPGP digital signature
Re: [gentoo-portage-dev] [PATCH v3 1/2] bin/install-qa-check.d: add new 90bad-bin-owner QA check.
On 08/07/2018 01:34 PM, Zac Medico wrote:
>
> Why not use ${ED%/} instead of ${D%/} here, so that the output is the
> same regardless of ${EPREFIX}?
>
We want to show where the executable was actually installed, and
generally that includes EPREFIX. For example, I'd want to see
/var/tmp/whatever/.../root/prefix/usr/bin/foo
reported as
/root/prefix/usr/bin/foo
rather than
/usr/bin/foo
Of course, these checks are now skipped on prefix systems anyway, so
it's a bit of a moot point. But I think it's more future-proof to strip
only the $D.
Re: [gentoo-portage-dev] [PATCH v3 1/2] bin/install-qa-check.d: add new 90bad-bin-owner QA check.
On 08/07/2018 09:46 AM, Michael Orlitzky wrote:
> + if [[ ${found[@]} ]]; then
> + eqawarn "system executables owned by nonzero uid:"
> + for f in "${found[@]}"; do
> + # Strip off the leading destdir before outputting the
> path.
> + eqawarn " ${f#${D%/}}"
Why not use ${ED%/} instead of ${D%/} here, so that the output is the
same regardless of ${EPREFIX}?
--
Thanks,
Zac
signature.asc
Description: OpenPGP digital signature
