Re: [geos-devel] Splitting _r and non _r functions in 2 different .h ?

2014-06-28 Thread Even Rouault
Le vendredi 20 juin 2014 09:55:32, Sandro Santilli a écrit : Please also take a look at this pending pull request for the re-entrant API: https://github.com/libgeos/libgeos/pull/26 It's blocked on naming, for the same reason you're doing this work (avoiding confusion) Hum, I've had a look

Re: [geos-devel] Splitting _r and non _r functions in 2 different .h ?

2014-06-20 Thread Sandro Santilli
Please also take a look at this pending pull request for the re-entrant API: https://github.com/libgeos/libgeos/pull/26 It's blocked on naming, for the same reason you're doing this work (avoiding confusion) --strk; On Wed, Jun 18, 2014 at 06:52:58PM +0200, Sandro Santilli wrote: On Wed, Jun

Re: [geos-devel] Splitting _r and non _r functions in 2 different .h ?

2014-06-18 Thread Even Rouault
Le mardi 17 juin 2014 23:07:52, Even Rouault a écrit : Hi, Currently it is difficult to ensure that ones code only uses the _r C API. I would propose to put the 2 kind of API into 2 separate files. geos_c_r.h would contain the _r C API only, and the few requirements (typedefs, etc...)

Re: [geos-devel] Splitting _r and non _r functions in 2 different .h ?

2014-06-18 Thread Sandro Santilli
On Wed, Jun 18, 2014 at 12:24:48PM +0200, Even Rouault wrote: Thinking more about this, for the sake of simplicity of user code of GEOS, I'd rather suggest geos.c.h: #ifndef USE_ONLY_GEOS_R_API Here go normal declarations (non X_r symbols) #endif Here go declarations of

Re: [geos-devel] Splitting _r and non _r functions in 2 different .h ?

2014-06-18 Thread Even Rouault
Le mercredi 18 juin 2014 17:17:36, Paul Ramsey a écrit : On Wed, Jun 18, 2014 at 3:24 AM, Even Rouault even.roua...@mines-paris.org wrote: Thinking more about this, for the sake of simplicity of user code of GEOS, I'd rather suggest geos.c.h: #ifndef USE_ONLY_GEOS_R_API Here go

Re: [geos-devel] Splitting _r and non _r functions in 2 different .h ?

2014-06-18 Thread Sandro Santilli
On Wed, Jun 18, 2014 at 06:32:25PM +0200, Even Rouault wrote: I've hit an integration problem with QGIS using the non _r API and spatialite calling (accidently) finishGEOS() when closing a spatialite DB, causing later crashes in QGIS. So I've converted all the QGIS calls to GEOS to the _r

[geos-devel] Splitting _r and non _r functions in 2 different .h ?

2014-06-17 Thread Even Rouault
Hi, Currently it is difficult to ensure that ones code only uses the _r C API. I would propose to put the 2 kind of API into 2 separate files. geos_c_r.h would contain the _r C API only, and the few requirements (typedefs, etc...) self sufficient so that libraries/applications using GEOS