Re: [geos-devel] GEOS cross-heap problems

2009-05-13 Thread strk
On Wed, May 13, 2009 at 12:19:23AM -0400, Frank Warmerdam wrote: Paul Ramsey wrote: I'd like to hear from others on this. OK - though I don't see the downside. Downstream packages only need to check for, and use GEOSFree() if they want. We are just adding a new option, not altering an

Re: [geos-devel] GEOS cross-heap problems

2009-05-13 Thread Frank Warmerdam
strk wrote: On Wed, May 13, 2009 at 12:19:23AM -0400, Frank Warmerdam wrote: Paul Ramsey wrote: I'd like to hear from others on this. OK - though I don't see the downside. Downstream packages only need to check for, and use GEOSFree() if they want. We are just adding a new option, not

Re: [geos-devel] GEOS cross-heap problems

2009-05-13 Thread Mateusz Loskot
Frank Warmerdam wrote: strk wrote: On Wed, May 13, 2009 at 12:19:23AM -0400, Frank Warmerdam wrote: Only, it'll have to stay (I've read Mateusz suggesting using type-specific destroyers). I cannot imagine why a type specific destroyer would be needed for simple malloc()/free() buffer

Re: [geos-devel] GEOS cross-heap problems

2009-05-13 Thread Sean Gillies
On May 13, 2009, at 7:42 AM, Mateusz Loskot wrote: Frank Warmerdam wrote: strk wrote: On Wed, May 13, 2009 at 12:19:23AM -0400, Frank Warmerdam wrote: Only, it'll have to stay (I've read Mateusz suggesting using type-specific destroyers). I cannot imagine why a type specific destroyer would

Re: [geos-devel] GEOS cross-heap problems

2009-05-13 Thread Frank Warmerdam
Sean Gillies wrote: On May 13, 2009, at 7:42 AM, Mateusz Loskot wrote: Frank Warmerdam wrote: strk wrote: On Wed, May 13, 2009 at 12:19:23AM -0400, Frank Warmerdam wrote: Only, it'll have to stay (I've read Mateusz suggesting using type-specific destroyers). I cannot imagine why a type

[geos-devel] GEOS cross-heap problems

2009-05-12 Thread Frank Warmerdam
Folks, I had a serious problem reported by a client of mine. The issue turned out to be that the OSGeo4W GEOS package was built with a different version of visual studio than the OSGeo4W GDAL package. The GDAL package calls: pabyBuf = GEOSGeomToWKB_buf( geosGeom, nSize ); ... free(

Re: [geos-devel] GEOS cross-heap problems

2009-05-12 Thread Frank Warmerdam
Frank Warmerdam wrote: Folks, I had a serious problem reported by a client of mine. The issue turned out to be that the OSGeo4W GEOS package was built with a different version of visual studio than the OSGeo4W GDAL package. The GDAL package calls: pabyBuf = GEOSGeomToWKB_buf( geosGeom,

Re: [geos-devel] GEOS cross-heap problems

2009-05-12 Thread Paul Ramsey
Frank, Please feel free to add the patch into trunk. Regarding API additions, I am feeling a little conservative. At a minimum, once you start doing that, all the downstream packages have to start testing for revision in order to know if they can call the feature. I'd like to hear from others

Re: [geos-devel] GEOS cross-heap problems

2009-05-12 Thread Frank Warmerdam
Paul Ramsey wrote: Frank, Please feel free to add the patch into trunk. Paul, Done (r2506). Details at: http://trac.osgeo.org/geos/ticket/249 Regarding API additions, I am feeling a little conservative. At a minimum, once you start doing that, all the downstream packages have to start

Re: [geos-devel] GEOS cross-heap problems

2009-05-12 Thread Paul Ramsey
Other comments? I have only vague discomfort, so in the absence of someone else having issues, I will subordinate my theoretical musing to Frank's practical need. P. On Tue, May 12, 2009 at 9:19 PM, Frank Warmerdam warmer...@pobox.com wrote: Paul Ramsey wrote: Frank, Please feel free to add