Re: [geos-devel] [GEOS] #970: CMake broken on winnie and appveyor (mingw64, VS) and travis

[GEOS]

#970: CMake broken on winnie and appveyor (mingw64, VS) and travis
+---
 Reporter:  robe|   Owner:  geos-devel@…
 Type:  defect  |  Status:  closed
 Priority:  major   |   Milestone:  3.8.0
Component:  Default | Version:  master
 Severity:  Unassigned  |  Resolution:  fixed
 Keywords:  |
+---

Comment (by Regina Obe ):

 In [changeset:"39ce10ea7fb7891b6c4f5a241c83a8dc46f8a1c7/git" 39ce10e/git]:
 {{{
 #!CommitTicketReference repository="git"
 revision="39ce10ea7fb7891b6c4f5a241c83a8dc46f8a1c7"
 Put back DISABLE_GEOS_INLINE and take out GEOS_ENABLE_INLINE.  Has clearer
 meaning though a breaking change. References #970
 }}}

-- 
Ticket URL: 
GEOS 
GEOS (Geometry Engine - Open Source) is a C++ port of the Java Topology Suite 
(JTS).
___
geos-devel mailing list
geos-devel@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/geos-devel

Re: [geos-devel] [GEOS] #970: CMake broken on winnie and appveyor (mingw64, VS) and travis

[GEOS]

#970: CMake broken on winnie and appveyor (mingw64, VS) and travis
+---
 Reporter:  robe|   Owner:  geos-devel@…
 Type:  defect  |  Status:  closed
 Priority:  major   |   Milestone:  3.8.0
Component:  Default | Version:  master
 Severity:  Unassigned  |  Resolution:  fixed
 Keywords:  |
+---
Changes (by robe):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 For the record I think this issue is fixed.

 On winnie I had:


 {{{
 -DGEOS_ENABLE_INLINE=NO
 }}}

 But this variable had been removed in
 
https://git.osgeo.org/gitea/geos/geos/commit/b15fd1171823d16195bee17f2c7b44778603258d

 and replaced with a reverse


 {{{
 DISABLE_GEOS_INLINE
 }}}

 In either case the default is to turn inlining ON.  But in using inlining
 on,

 I would get these errors in CMAKE for mingw64 building:


 {{{
 CMakeFiles/geos.dir/objects.a(inlines.cpp.obj):inlines.cpp:(.text+0x658):
 multiple definition of `geos::geomgraph::DirectedEdge::isInResult()'
 
CMakeFiles/geos.dir/objects.a(DirectedEdgeStar.cpp.obj):DirectedEdgeStar.cpp:(.text$_ZN4geos9geomgraph12DirectedEdge10isInResultEv[_ZN4geos9geomgraph12DirectedEdge10isInResultEv]+0x0):
 first defined here
 CMakeFiles/geos.dir/objects.a(inlines.cpp.obj):inlines.cpp:(.text+0x684):
 multiple definition of `geos::geomgraph::DirectedEdge::setVisited(bool)'
 
CMakeFiles/geos.dir/objects.a(DirectedEdge.cpp.obj):DirectedEdge.cpp:(.text$_ZN4geos9geomgraph12DirectedEdge10setVisitedEb[_ZN4geos9geomgraph12DirectedEdge10setVisitedEb]+0x0):
 first defined here
 CMakeFiles/geos.dir/objects.a(inlines.cpp.obj):inlines.cpp:(.text+0x6c0):
 multiple definition of `geos::geomgraph::DirectedEdge::getEdgeRing()'
 
CMakeFiles/geos.dir/objects.a(DirectedEdgeStar.cpp.obj):DirectedEdgeStar.cpp:(.text$_ZN4geos9geomgraph12DirectedEdge11getEdgeRingEv[_ZN4geos9geomgraph12DirectedEdge11getEdgeRingEv]+0x0):
 first defined here
 CMakeFiles/geos.dir/objects.a(inlines.cpp.obj):inlines.cpp:(.text+0x70a):
 multiple definition of `geos::geomgraph::DirectedEdge::getDepth(int)'
 
CMakeFiles/geos.dir/objects.a(DirectedEdgeStar.cpp.obj):DirectedEdgeStar.cpp:(.text$_ZN4geos9geomgraph12DirectedEdge8getDepthEi[_ZN4geos9geomgraph12DirectedEdge8getDepthEi]+0x0):
 first defined here
 CMakeFiles/geos.dir/objects.a(inlines.cpp.obj):inlines.cpp:(.text+0x72a):
 multiple definition of `geos::geomgraph::DirectedEdge::getSym()'
 
CMakeFiles/geos.dir/objects.a(DirectedEdgeStar.cpp.obj):DirectedEdgeStar.cpp:(.text$_ZN4geos9geomgraph12DirectedEdge6getSymEv[_ZN4geos9geomgraph12DirectedEdge6getSymEv]+0x0):
 first defined here
 CMakeFiles/geos.dir/objects.a(inlines.cpp.obj):inlines.cpp:(.text+0x740):
 multiple definition of `geos::geomgraph::DirectedEdge::isForward()'
 
CMakeFiles/geos.dir/objects.a(EdgeRing.cpp.obj):EdgeRing.cpp:(.text$_ZN4geos9geomgraph12DirectedEdge9isForwardEv[_ZN4geos9geomgraph12DirectedEdge9isForwardEv]+0x0):
 first defined here
 CMakeFiles/geos.dir/objects.a(inlines.cpp.obj):inlines.cpp:(.text+0x756):
 multiple definition of
 `geos::geomgraph::DirectedEdge::setSym(geos::geomgraph::DirectedEdge*)'
 
CMakeFiles/geos.dir/objects.a(PlanarGraph.cpp.obj):PlanarGraph.cpp:(.text$_ZN4geos9geomgraph12DirectedEdge6setSymEPS1_[_ZN4geos9geomgraph12DirectedEdge6setSymEPS1_]+0x0):
 first defined here
 CMakeFiles/geos.dir/objects.a(inlines.cpp.obj):inlines.cpp:(.text+0x774):
 multiple definition of `geos::geomgraph::DirectedEdge::getNext()'
 
CMakeFiles/geos.dir/objects.a(EdgeRing.cpp.obj):EdgeRing.cpp:(.text$_ZN4geos9geomgraph12DirectedEdge7getNextEv[_ZN4geos9geomgraph12DirectedEdge7getNextEv]+0x0):
 first defined here
 CMakeFiles/geos.dir/objects.a(inlines.cpp.obj):inlines.cpp:(.text+0x78a):
 multiple definition of
 `geos::geomgraph::DirectedEdge::setNext(geos::geomgraph::DirectedEdge*)'
 
CMakeFiles/geos.dir/objects.a(DirectedEdgeStar.cpp.obj):DirectedEdgeStar.cpp:(.text$_ZN4geos9geomgraph12DirectedEdge7setNextEPS1_[_ZN4geos9geomgraph12DirectedEdge7setNextEPS1_]+0x0):
 first defined here
 CMakeFiles/geos.dir/objects.a(inlines.cpp.obj):inlines.cpp:(.text+0x7be):
 multiple definition of
 `geos::geomgraph::DirectedEdge::setNextMin(geos::geomgraph::DirectedEdge*)'
 
CMakeFiles/geos.dir/objects.a(DirectedEdgeStar.cpp.obj):DirectedEdgeStar.cpp:(.text$_ZN4geos9geomgraph12DirectedEdge10setNextMinEPS1_[_ZN4geos9geomgraph12DirectedEdge10setNextMinEPS1_]+0x0):
 first defined here
 CMakeFiles/geos.dir/objects.a(inlines.cpp.obj):inlines.cpp:(.text+0x7dc):
 multiple definition of
 
`geos::geomgraph::GeometryGraph::getBoundaryNodes(std::vector >&)'
 
CMakeFiles/geos.dir/objects.a(GeometryGraph.cpp.obj):GeometryGraph.cpp:(.text$_ZN4geos9geomgraph13GeometryGraph16getBoundaryNodesERSt6vectorIPNS0_4NodeESaIS4_EE[_ZN4geos9geomgraph13GeometryGraph16getBoundaryNodesERSt6vectorIPNS0_4NodeESaIS4_EE]+0x0):
 first defined here
 

Re: [geos-devel] [GEOS] #970: CMake broken on winnie and appveyor (mingw64, VS) and travis

[GEOS]

#970: CMake broken on winnie and appveyor (mingw64, VS) and travis
+---
 Reporter:  robe|   Owner:  geos-devel@…
 Type:  defect  |  Status:  new
 Priority:  major   |   Milestone:  3.8.0
Component:  Default | Version:  master
 Severity:  Unassigned  |  Resolution:
 Keywords:  |
+---

Comment (by mloskot):

 Must be a different issue then.

 On Linux all builds fine. On Windows, there seem to be only some ttmath
 issues.

-- 
Ticket URL: 
GEOS 
GEOS (Geometry Engine - Open Source) is a C++ port of the Java Topology Suite 
(JTS).
___
geos-devel mailing list
geos-devel@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/geos-devel

Re: [geos-devel] [GEOS] #970: CMake broken on winnie and appveyor (mingw64, VS) and travis (was: CMAke broken on winnie and appveyor (mingw64, VS) and travis)

[GEOS]

#970: CMake broken on winnie and appveyor (mingw64, VS) and travis
+---
 Reporter:  robe|   Owner:  geos-devel@…
 Type:  defect  |  Status:  new
 Priority:  major   |   Milestone:  3.8.0
Component:  Default | Version:  master
 Severity:  Unassigned  |  Resolution:
 Keywords:  |
+---

-- 
Ticket URL: 
GEOS 
GEOS (Geometry Engine - Open Source) is a C++ port of the Java Topology Suite 
(JTS).
___
geos-devel mailing list
geos-devel@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/geos-devel

Re: [geos-devel] [GEOS] #970: CMAke broken on winnie and appveyor (mingw64, VS) and travis

[GEOS]

#970: CMAke broken on winnie and appveyor (mingw64, VS) and travis
+---
 Reporter:  robe|   Owner:  geos-devel@…
 Type:  defect  |  Status:  new
 Priority:  major   |   Milestone:  3.8.0
Component:  Default | Version:  master
 Severity:  Unassigned  |  Resolution:
 Keywords:  |
+---

Comment (by robe):

 Upgraded winnie to latest cmake which is 3.14.4 and that did not fix her
 issue

-- 
Ticket URL: 
GEOS 
GEOS (Geometry Engine - Open Source) is a C++ port of the Java Topology Suite 
(JTS).
___
geos-devel mailing list
geos-devel@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/geos-devel

Re: [geos-devel] [GEOS] #970: CMAke broken on winnie and appveyor (mingw64, VS) and travis

[GEOS]

#970: CMAke broken on winnie and appveyor (mingw64, VS) and travis
+---
 Reporter:  robe|   Owner:  geos-devel@…
 Type:  defect  |  Status:  new
 Priority:  major   |   Milestone:  3.8.0
Component:  Default | Version:  master
 Severity:  Unassigned  |  Resolution:
 Keywords:  |
+---

Comment (by mloskot):

 Install newer CMake - Kitware makes it very easy do, e.g. like so

 https://github.com/mloskot/wsl-config/blob/master/scripts/install-cmake-
 latest.ps1
 https://github.com/mloskot/wsl-config/blob/master/scripts/install-cmake-
 latest.sh

 or tweak the lines here:

 https://github.com/libgeos/geos/blob/master/CMakeLists.txt#L16-L19

-- 
Ticket URL: 
GEOS 
GEOS (Geometry Engine - Open Source) is a C++ port of the Java Topology Suite 
(JTS).
___
geos-devel mailing list
geos-devel@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/geos-devel

Re: [geos-devel] [GEOS] #970: CMAke broken on winnie and appveyor (mingw64, VS) and travis (was: CMAke broken on winnie and appveyor (mingw64, VS))

[GEOS]

#970: CMAke broken on winnie and appveyor (mingw64, VS) and travis
+---
 Reporter:  robe|   Owner:  geos-devel@…
 Type:  defect  |  Status:  new
 Priority:  major   |   Milestone:  3.8.0
Component:  Default | Version:  master
 Severity:  Unassigned  |  Resolution:
 Keywords:  |
+---

Comment (by robe):

 Just checked even our happy go luck travis cmake runs are failing.


 {{{
 -- GEOS: C API soversion 11
 -- GEOS: JTS port 1.13.0
 -- GEOS: Require C++11
 -- GEOS: Developer mode enabled
 CMake Error at tests/xmltester/CMakeLists.txt:15 (add_executable):
   add_executable called with incorrect number of arguments
 CMake Error at tests/xmltester/CMakeLists.txt:16 (target_sources):
   Cannot specify sources for target "test_xmltester" which is not built by
   this project.
 CMake Error at tests/xmltester/CMakeLists.txt:23 (target_link_libraries):
   Cannot specify link libraries for target "test_xmltester" which is not
   built by this project.

 }}}

-- 
Ticket URL: 
GEOS 
GEOS (Geometry Engine - Open Source) is a C++ port of the Java Topology Suite 
(JTS).
___
geos-devel mailing list
geos-devel@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/geos-devel

[geos-devel] [GEOS] #970: CMAke broken on winnie and appveyor (mingw64, VS)

[GEOS]

#970: CMAke broken on winnie and appveyor (mingw64, VS)
+--
 Reporter:  robe|  Owner:  geos-devel@…
 Type:  defect  | Status:  new
 Priority:  major   |  Milestone:  3.8.0
Component:  Default |Version:  master
 Severity:  Unassigned  |   Keywords:
+--
 Seems as a result of change

 
https://git.osgeo.org/gitea/geos/geos/commit/b15fd1171823d16195bee17f2c7b44778603258d

 Might be just the cmake needs upgrading on both.


 {{{
 Commit 1aedfca497d6de23bd3a857191da10b98b6b01f0 by mateusz

 Modernize CMake configuration
 Refactoring based on practices of the Modern CMake approach:
 * Set project version based on `version.txt` spec.
 * Build shared libraries by default.
 * Build tools and `geos-config` script.
 * Add make `check` target to run `ctest` (no dependencies).
 * Move failing/overlarge tests into `failure` directory.
 * Add target to deploy Config-module with installed targets:
  `GEOS::geos`, `GEOS::geos_c`.
 * Add basic uninstall target
 * Add basic client example configured with CMake to use GEOS targets.
 }}}


 Both winnie and appveyor are broken

 On Winnie (which is running mingw64, but using  general windows compiled
 cmake) I get this - FWIW the cmake version in use is CMake 3.12.1 on
 winnie.
 I'll upgrade to see if it fixes the issue.


 {{{
 -- The C compiler identification is GNU 8.1.0
 -- The CXX compiler identification is GNU 8.1.0
 -- Check for working C compiler: C:/ming64gcc81/mingw64/bin/gcc.exe
 -- Check for working C compiler: C:/ming64gcc81/mingw64/bin/gcc.exe --
 works
 -- Detecting C compiler ABI info
 -- Detecting C compiler ABI info - done
 -- Detecting C compile features
 -- Detecting C compile features - done
 -- Check for working CXX compiler: C:/ming64gcc81/mingw64/bin/g++.exe
 -- Check for working CXX compiler: C:/ming64gcc81/mingw64/bin/g++.exe --
 works
 -- Detecting CXX compiler ABI info
 -- Detecting CXX compiler ABI info - done
 -- Detecting CXX compile features
 -- Detecting CXX compile features - done
 -- GEOS: Version 3.8.0-dev
 -- GEOS: C API soversion
 -- GEOS: JTS port 1.13.0
 -- GEOS: Require C++11
 -- GEOS: Developer mode enabled
 -- Configuring done
 -- Generating done
 :
 Unable to find executable:
 
E:/jenkins/geos/branches/build64cmake/tests/perf/operation/predicate/test_perf_rectangle_intersects.exe
 6/7 Test #6: test_perf_rectangle_intersects ...***Not Run   0.00 sec
 Start 7: test_perf_memleak_mp_prep
 Could not find executable
 
E:/jenkins/geos/branches/build64cmake/tests/perf/capi/test_perf_memleak_mp_prep.exe
 Looked in the following places:
 
E:/jenkins/geos/branches/build64cmake/tests/perf/capi/test_perf_memleak_mp_prep.exe
 
E:/jenkins/geos/branches/build64cmake/tests/perf/capi/test_perf_memleak_mp_prep.exe.exe
 
E:/jenkins/geos/branches/build64cmake/tests/perf/capi/Release/test_perf_memleak_mp_prep.exe
 
E:/jenkins/geos/branches/build64cmake/tests/perf/capi/Release/test_perf_memleak_mp_prep.exe.exe
 
E:/jenkins/geos/branches/build64cmake/tests/perf/capi/Debug/test_perf_memleak_mp_prep.exe
 
E:/jenkins/geos/branches/build64cmake/tests/perf/capi/Debug/test_perf_memleak_mp_prep.exe.exe
 
E:/jenkins/geos/branches/build64cmake/tests/perf/capi/MinSizeRel/test_perf_memleak_mp_prep.exe
 
E:/jenkins/geos/branches/build64cmake/tests/perf/capi/MinSizeRel/test_perf_memleak_mp_prep.exe.exe
 
E:/jenkins/geos/branches/build64cmake/tests/perf/capi/RelWithDebInfo/test_perf_memleak_mp_prep.exe
 
E:/jenkins/geos/branches/build64cmake/tests/perf/capi/RelWithDebInfo/test_perf_memleak_mp_prep.exe.exe
 
E:/jenkins/geos/branches/build64cmake/tests/perf/capi/Deployment/test_perf_memleak_mp_prep.exe
 
E:/jenkins/geos/branches/build64cmake/tests/perf/capi/Deployment/test_perf_memleak_mp_prep.exe.exe
 
E:/jenkins/geos/branches/build64cmake/tests/perf/capi/Development/test_perf_memleak_mp_prep.exe
 
E:/jenkins/geos/branches/build64cmake/tests/perf/capi/Development/test_perf_memleak_mp_prep.exe.exe
 Unable to find executable:
 
E:/jenkins/geos/branches/build64cmake/tests/perf/capi/test_perf_memleak_mp_prep.exe
 7/7 Test #7: test_perf_memleak_mp_prep ***Not Run   0.00 sec

 0% tests passed, 7 tests failed out of 7

 Total Test time (real) =   0.04 sec

 The following tests FAILED:
   1 - test_geos_unit (Not Run)
   2 - test_xmltester (Not Run)
   3 - test_bug234 (Not Run)
   4 - test_perf_class_sizes (Not Run)
   5 - test_perf_iterated_buffer (Not Run)
   6 - test_perf_rectangle_intersects (Not Run)
   7 - test_perf_memleak_mp_prep (Not Run)
 Errors while running CTest
 make[3]: *** [tests/CMakeFiles/check.dir/build.make:57:
 tests/CMakeFiles/check] Error 8
 make[2]: *** [CMakeFiles/Makefile2:1190: tests/CMakeFiles/check.dir/all]
 Error 2
 make[1]: *** [CMakeFiles/Makefile2:1197: tests/CMakeFiles/check.dir/rule]
 Error 2
 make: *** [Makefile:591: check] Error 2

 }}}

 Appveyor's