Re: [geos-devel] [GEOS] #859: Voronoi issue

2022-12-12 Thread GEOS
#859: Voronoi issue
+---
 Reporter:  jjgreen |   Owner:  geos-devel@…
 Type:  defect  |  Status:  closed
 Priority:  major   |   Milestone:  3.6.6
Component:  Default | Version:  3.5.1
 Severity:  Unassigned  |  Resolution:  fixed
 Keywords:  |
+---
Changes (by dbaston):

 * status:  new => closed
 * resolution:   => fixed

-- 
Ticket URL: 
GEOS 
GEOS (Geometry Engine - Open Source) is a C++ port of the Java Topology Suite 
(JTS).___
geos-devel mailing list
geos-devel@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/geos-devel


Re: [geos-devel] [GEOS] #859: Voronoi issue

2020-11-06 Thread GEOS
#859: Voronoi issue
+---
 Reporter:  jjgreen |   Owner:  geos-devel@…
 Type:  defect  |  Status:  new
 Priority:  major   |   Milestone:  3.6.4
Component:  Default | Version:  3.5.1
 Severity:  Unassigned  |  Resolution:
 Keywords:  |
+---

Comment (by mdavis):

 I did run this against master as a C++ unit test (but didn't commit it
 because data is so large).  I can commit it if that seems like a good idea
 (there is a unit test which is a subset of this data though).

 Or, have been thinking about adding ability to run Delaunay and Voronoi as
 XML tests (should be fairly easy).

-- 
Ticket URL: 
GEOS 
GEOS (Geometry Engine - Open Source) is a C++ port of the Java Topology Suite 
(JTS).
___
geos-devel mailing list
geos-devel@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/geos-devel

Re: [geos-devel] [GEOS] #859: Voronoi issue

2020-11-06 Thread GEOS
#859: Voronoi issue
+---
 Reporter:  jjgreen |   Owner:  geos-devel@…
 Type:  defect  |  Status:  new
 Priority:  major   |   Milestone:  3.6.4
Component:  Default | Version:  3.5.1
 Severity:  Unassigned  |  Resolution:
 Keywords:  |
+---

Comment (by strk):

 Time to re-test this against master or 3.8 branches (see
 https://trac.osgeo.org/geos/ticket/976#comment:25)

-- 
Ticket URL: 
GEOS 
GEOS (Geometry Engine - Open Source) is a C++ port of the Java Topology Suite 
(JTS).
___
geos-devel mailing list
geos-devel@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/geos-devel

Re: [geos-devel] [GEOS] #859: Voronoi issue

2020-11-03 Thread GEOS
#859: Voronoi issue
+---
 Reporter:  jjgreen |   Owner:  geos-devel@…
 Type:  defect  |  Status:  new
 Priority:  major   |   Milestone:  3.6.4
Component:  Default | Version:  3.5.1
 Severity:  Unassigned  |  Resolution:
 Keywords:  |
+---

Comment (by mdavis):

 Verified that the original data on this issue is fixed by using
 circumcentreDD (with no heuristic).

 Note that #976 is testing a subset of this data, which also fails:
 {{{
 
0104801700010180EC51B81E11A20741EC51B81E85A51C415C8FC2F528DC35400101801F85EB5114A207415C8FC2F585A51C417B14AE47E1BA354001018085EB51B818A20741A8C64B3786A51C413E0AD7A3709D35400101801BA20741FED478E984A51C413E0AD7A3709D354001018085EB51B818A20741FED478E984A51C413E0AD7A3709D35400101800AD7A37016A20741FED478E984A51C413E0AD7A3709D35400101801BA2074154E3A59B83A51C413E0AD7A3709D354001018085EB51B818A2074154E3A59B83A51C413E0AD7A3709D35400101800AD7A37016A2074154E3A59B83A51C413E0AD7A3709D35400101801BA20741AAF1D24D82A51C413E0AD7A3709D354001018085EB51B818A20741AAF1D24D82A51C413E0AD7A3709D3540010180F6285C8F12A20741EC51B81E88A51C414160E5D022DB354001018010A2074152B81EC586A51C414160E5D022DB35400101804F1BE8B40DA2074152B81EC586A51C414160E5D022DB35400101807B14AE470BA2074152B81EC586A51C414160E5D022DB354001018010A20741B81E856B85A51C414160E5D022DB35400101804F1BE8B40DA20741B81E856B85A51C414160E5D022DB35400101807B14AE470BA20741B81E856B85A51C414160E5D022DB3540010180A70D74DA08A20741B81E856B85A51C414160E5D022DB3540010180D4063A6D06A20741B81E856B85A51C414160E5D022DB35400101807B14AE470BA207411F85EB1184A51C414160E5D022DB3540010180A70D74DA08A207411F85EB1184A51C414160E5D022DB3540010180D4063A6D06A207411F85EB1184A51C414160E5D022DB3540
 }}}

-- 
Ticket URL: 
GEOS 
GEOS (Geometry Engine - Open Source) is a C++ port of the Java Topology Suite 
(JTS).
___
geos-devel mailing list
geos-devel@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/geos-devel

Re: [geos-devel] [GEOS] #859: Voronoi issue

2020-11-03 Thread GEOS
#859: Voronoi issue
+---
 Reporter:  jjgreen |   Owner:  geos-devel@…
 Type:  defect  |  Status:  new
 Priority:  major   |   Milestone:  3.6.4
Component:  Default | Version:  3.5.1
 Severity:  Unassigned  |  Resolution:
 Keywords:  |
+---

Comment (by mdavis):

 Using DD precision for circumcentre actually fixes this issue.  But the
 
[https://github.com/libgeos/geos/blob/master/src/triangulate/quadedge/QuadEdgeSubdivision.cpp#L398
 isocelese triangle heuristic] for performance doesn't work. This is why
 the unit test fails when it is fixed to use an appropriate tolerance.

-- 
Ticket URL: 
GEOS 
GEOS (Geometry Engine - Open Source) is a C++ port of the Java Topology Suite 
(JTS).
___
geos-devel mailing list
geos-devel@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/geos-devel

Re: [geos-devel] [GEOS] #859: Voronoi issue

2020-11-03 Thread GEOS
#859: Voronoi issue
+---
 Reporter:  jjgreen |   Owner:  geos-devel@…
 Type:  defect  |  Status:  new
 Priority:  major   |   Milestone:  3.6.4
Component:  Default | Version:  3.5.1
 Severity:  Unassigned  |  Resolution:
 Keywords:  |
+---

Comment (by mdavis):

 Replying to [comment:6 Paul Ramsey ]:

 > Curiously, this case blows an exception on PostGIS, but not in the unit
 test.

 The reason the unit test passes is that the triangulation tolerance value
 (100) is larger than the extent of the input geometry.  This causes the
 data to collapse to a point, which produces an empty Voronoi diagram.  If
 a smaller tolerance (say 0.1) is used then the test fails with a Topo
 exception.

-- 
Ticket URL: 
GEOS 
GEOS (Geometry Engine - Open Source) is a C++ port of the Java Topology Suite 
(JTS).
___
geos-devel mailing list
geos-devel@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/geos-devel

Re: [geos-devel] [GEOS] #859: Voronoi issue

2019-10-01 Thread GEOS
#859: Voronoi issue
+---
 Reporter:  jjgreen |   Owner:  geos-devel@…
 Type:  defect  |  Status:  new
 Priority:  major   |   Milestone:  3.6.4
Component:  Default | Version:  3.5.1
 Severity:  Unassigned  |  Resolution:
 Keywords:  |
+---

Comment (by Paul Ramsey ):

 In [changeset:"2036448ae9ef15ef026ff5b5bb6acbff119c75c3/git" 2036448/git]:
 {{{
 #!CommitTicketReference repository="git"
 revision="2036448ae9ef15ef026ff5b5bb6acbff119c75c3"
 Add trimmed down test case on Voronoi.
 Curiously, this case blows an exception on PostGIS, but not in the unit
 test.
 References #859
 }}}

-- 
Ticket URL: 
GEOS 
GEOS (Geometry Engine - Open Source) is a C++ port of the Java Topology Suite 
(JTS).
___
geos-devel mailing list
geos-devel@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/geos-devel

Re: [geos-devel] [GEOS] #859: Voronoi issue

2019-09-18 Thread GEOS
#859: Voronoi issue
+---
 Reporter:  jjgreen |   Owner:  geos-devel@…
 Type:  defect  |  Status:  new
 Priority:  major   |   Milestone:  3.6.4
Component:  Default | Version:  3.5.1
 Severity:  Unassigned  |  Resolution:
 Keywords:  |
+---

Comment (by pramsey):

 Not fixed, just tested on latest trunk.

-- 
Ticket URL: 
GEOS 
GEOS (Geometry Engine - Open Source) is a C++ port of the Java Topology Suite 
(JTS).
___
geos-devel mailing list
geos-devel@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/geos-devel

Re: [geos-devel] [GEOS] #859: Voronoi issue

2019-07-28 Thread GEOS
#859: Voronoi issue
+---
 Reporter:  jjgreen |   Owner:  geos-devel@…
 Type:  defect  |  Status:  new
 Priority:  major   |   Milestone:  3.6.4
Component:  Default | Version:  3.5.1
 Severity:  Unassigned  |  Resolution:
 Keywords:  |
+---

Comment (by mdavis):

 This problem does appear to be caused by input points which lie on a grid,
 so this is probably fixed by #976

-- 
Ticket URL: 
GEOS 
GEOS (Geometry Engine - Open Source) is a C++ port of the Java Topology Suite 
(JTS).
___
geos-devel mailing list
geos-devel@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/geos-devel

Re: [geos-devel] [GEOS] #859: Voronoi issue

2019-07-28 Thread GEOS
#859: Voronoi issue
+---
 Reporter:  jjgreen |   Owner:  geos-devel@…
 Type:  defect  |  Status:  new
 Priority:  major   |   Milestone:  3.6.4
Component:  Default | Version:  3.5.1
 Severity:  Unassigned  |  Resolution:
 Keywords:  |
+---

Comment (by komzpa):

 Hi, there was a gridded voronoi robustness fix in #976. Maybe this one is
 fixed on master too?

-- 
Ticket URL: 
GEOS 
GEOS (Geometry Engine - Open Source) is a C++ port of the Java Topology Suite 
(JTS).
___
geos-devel mailing list
geos-devel@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/geos-devel

Re: [geos-devel] [GEOS] #859: Voronoi issue

2018-08-18 Thread GEOS
#859: Voronoi issue
+---
 Reporter:  jjgreen |   Owner:  geos-devel@…
 Type:  defect  |  Status:  new
 Priority:  major   |   Milestone:  3.6.4
Component:  Default | Version:  3.5.1
 Severity:  Unassigned  |  Resolution:
 Keywords:  |
+---
Changes (by robe):

 * milestone:  3.7.0 => 3.6.4


-- 
Ticket URL: 
GEOS 
GEOS (Geometry Engine - Open Source) is a C++ port of the Java Topology Suite 
(JTS).
___
geos-devel mailing list
geos-devel@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/geos-devel

Re: [geos-devel] [GEOS] #859: Voronoi issue

2018-08-04 Thread GEOS
#859: Voronoi issue
+---
 Reporter:  jjgreen |   Owner:  geos-devel@…
 Type:  defect  |  Status:  new
 Priority:  major   |   Milestone:  3.7.0
Component:  Default | Version:  3.5.1
 Severity:  Unassigned  |  Resolution:
 Keywords:  |
+---
Changes (by robe):

 * milestone:  3.5.2 => 3.7.0


Comment:

 Still an issue even with 3.7.0beta1.

-- 
Ticket URL: 
GEOS 
GEOS (Geometry Engine - Open Source) is a C++ port of the Java Topology Suite 
(JTS).
___
geos-devel mailing list
geos-devel@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/geos-devel

Re: [geos-devel] [GEOS] #859: Voronoi issue

2018-02-28 Thread GEOS
#859: Voronoi issue
+---
 Reporter:  jjgreen |   Owner:  geos-devel@…
 Type:  defect  |  Status:  new
 Priority:  major   |   Milestone:  3.5.2
Component:  Default | Version:  3.5.1
 Severity:  Unassigned  |  Resolution:
 Keywords:  |
+---
Changes (by jjgreen):

 * Attachment "reproduce.sh" added.

 script which reproduces the issue

-- 
Ticket URL: 
GEOS 
GEOS (Geometry Engine - Open Source) is a C++ port of the Java Topology Suite 
(JTS).
___
geos-devel mailing list
geos-devel@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/geos-devel

Re: [geos-devel] [GEOS] #859: Voronoi issue

2018-02-28 Thread GEOS
#859: Voronoi issue
+---
 Reporter:  jjgreen |   Owner:  geos-devel@…
 Type:  defect  |  Status:  new
 Priority:  major   |   Milestone:  3.5.2
Component:  Default | Version:  3.5.1
 Severity:  Unassigned  |  Resolution:
 Keywords:  |
+---
Changes (by jjgreen):

 * Attachment "fedje.csv" added.

 data points

-- 
Ticket URL: 
GEOS 
GEOS (Geometry Engine - Open Source) is a C++ port of the Java Topology Suite 
(JTS).
___
geos-devel mailing list
geos-devel@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/geos-devel