Re: [Geoserver-devel] GSIP-206 Promote GeoPackage to extension

2022-01-10 Thread Simone Giannecchini
Thank you for the clarification. Regards, Simone Giannecchini == GeoServer Professional Services from the experts! Visit http://bit.ly/gs-services for more information. == Ing. Simone Giannecchini @simogeo Founder/Director GeoSolutions Italy President GeoSolutions USA phone: +39 0584 962313 fax:

Re: [Geoserver-devel] GSIP-206 Promote GeoPackage to extension

2022-01-10 Thread Jody Garnett
Thanks Simone: The GeoPkgDataStoreFactoryInitilizer is Datastore specific, and the Datastore was added to core some time ago and apparently this helper class helps the geotools datastore factory operate correctly. - I am not sure why the initilier was not added at the time (its job is to

Re: [Geoserver-devel] GSIP 207, feature type info customization

2022-01-10 Thread Nuno Oliveira
Great, thank you for the clarification, +1. On Mon, Jan 10, 2022 at 2:02 PM Andrea Aime < andrea.a...@geosolutionsgroup.com> wrote: > On Thu, Jan 6, 2022 at 9:57 PM Nuno Oliveira < > nuno.olive...@geosolutionsgroup.com> wrote: > >> Hi all, Andrea, >> looks good to me, just a couple of comments:

Re: [Geoserver-devel] GSIP-206 Promote GeoPackage to extension

2022-01-10 Thread Alessio Fabiani
+1 here On Mon, Jan 10, 2022 at 10:54 AM Simone Giannecchini < simone.giannecch...@geosolutionsgroup.com> wrote: > Hi Jody, > I am +0 now. > Two things: > - I don't want to be involved too much with the coding but this part > surprised me: > "To migrate to core:

Re: [Geoserver-devel] GSIP 207, feature type info customization

2022-01-10 Thread Alessio Fabiani
+1 here On Mon, Jan 10, 2022 at 3:06 PM Andrea Aime < andrea.a...@geosolutionsgroup.com> wrote: > On Thu, Jan 6, 2022 at 9:57 PM Nuno Oliveira < > nuno.olive...@geosolutionsgroup.com> wrote: > >> Hi all, Andrea, >> looks good to me, just a couple of comments: >> >>- Is the identifier (ID

Re: [Geoserver-devel] GSIP 207, feature type info customization

2022-01-10 Thread Andrea Aime
On Thu, Jan 6, 2022 at 9:57 PM Nuno Oliveira < nuno.olive...@geosolutionsgroup.com> wrote: > Hi all, Andrea, > looks good to me, just a couple of comments: > >- Is the identifier (ID attribute) of the feature type fixed? I'm >assuming it is. > > Yes, it is. >- If we define a new

Re: [Geoserver-devel] GSIP-206 Promote GeoPackage to extension

2022-01-10 Thread Simone Giannecchini
Hi Jody, I am +0 now. Two things: - I don't want to be involved too much with the coding but this part surprised me: "To migrate to core: GeoPkgDataStoreFactoryInitializer.java this should of been done previously as part of adding datastore support" Do we really need to have plugin specific code