Re: [Geoserver-devel] FormatOptionsKvpParser weird behaviour

2014-06-25 Thread Justin Deoliveira
On Wed, Jun 25, 2014 at 8:51 AM, Mauro Bartolomeoli < mauro.bartolome...@geo-solutions.it> wrote: > Hi Justin, > > >> I am thinking that changing the signature of KvpParser is a pretty >> invasive change, and that we should avoid it if possible. I am also >> thinking it is kind of letting some imp

Re: [Geoserver-devel] FormatOptionsKvpParser weird behaviour

2014-06-25 Thread Mauro Bartolomeoli
Hi Justin, > I am thinking that changing the signature of KvpParser is a pretty > invasive change, and that we should avoid it if possible. I am also > thinking it is kind of letting some implementation details creep into what > is now a pretty simple interface. > > Perhaps I am not understanding

Re: [Geoserver-devel] FormatOptionsKvpParser weird behaviour

2014-06-25 Thread Justin Deoliveira
On Wed, Jun 25, 2014 at 8:08 AM, Mauro Bartolomeoli < mauro.bartolome...@geo-solutions.it> wrote: > Hi, > > > 2014-06-25 15:28 GMT+02:00 Justin Deoliveira : > > >> at options string to a map and threw it into KvpUtils.parse() that would work? >>> >>> The problem is that KvpUtils.parse e

Re: [Geoserver-devel] FormatOptionsKvpParser weird behaviour

2014-06-25 Thread Mauro Bartolomeoli
Hi, 2014-06-25 15:28 GMT+02:00 Justin Deoliveira : > > at options string to a map and threw it into KvpUtils.parse() that would >>> work? >>> >> >> The problem is that KvpUtils.parse expects info on the current service, >> version and so on to filter out unneeded parsers. My idea would be to >>

Re: [Geoserver-devel] FormatOptionsKvpParser weird behaviour

2014-06-25 Thread Justin Deoliveira
On Wed, Jun 25, 2014 at 1:21 AM, Mauro Bartolomeoli < mauro.bartolome...@geo-solutions.it> wrote: > Hi Justin, > > > 2014-06-24 19:28 GMT+02:00 Justin Deoliveira : > > Hey Mauro, >> >> So what about having FormatOptionsKvpParser delegating to the same >> KvpUtils.parse() method that the main kvp p

Re: [Geoserver-devel] FormatOptionsKvpParser weird behaviour

2014-06-25 Thread Mauro Bartolomeoli
Hi Justin, 2014-06-24 19:28 GMT+02:00 Justin Deoliveira : > Hey Mauro, > > So what about having FormatOptionsKvpParser delegating to the same > KvpUtils.parse() method that the main kvp parsing chain does? I haven't > looked too deep but it seems like if we just parsed the format options > strin

Re: [Geoserver-devel] FormatOptionsKvpParser weird behaviour

2014-06-24 Thread Justin Deoliveira
Hey Mauro, So what about having FormatOptionsKvpParser delegating to the same KvpUtils.parse() method that the main kvp parsing chain does? I haven't looked too deep but it seems like if we just parsed the format options string to a map and threw it into KvpUtils.parse() that would work? On Tue,

[Geoserver-devel] FormatOptionsKvpParser weird behaviour

2014-06-24 Thread Mauro Bartolomeoli
Hi, while trying to patch the dxf extension for GEOS-6402, I encountered a weird behaviour in FormatOptionsKvpParser. Basically, that parser ignores the current service, version and doesn't purge the list of available parser as KvpUtils.parse does, so it can happen that parsers defined by a differe