Re: [Geoserver-devel] Paths utility class

2023-09-13 Thread Jody Garnett
I agree Niels, Let’s try and get this in before the RC which is (checks watch next Thursday). My priorities are that the api be clear (confusing is terrible); that path be handled the same way internally everywhere (a strong response to earlier confusion); and that ResourceStore make no assumptio

Re: [Geoserver-devel] Paths utility class

2023-09-13 Thread Niels Charlier via Geoserver-devel
Hello Jody, We have a very different way of looking at things, but what matters most is to find a solution moving forward even if we cannot convince each other. So let's try to focus on what we each find most important and try to find a compromise that respects both sides. The resource store

Re: [Geoserver-devel] Paths utility class

2023-09-13 Thread Jody Garnett
You are arriving with this right as we try and find volunteers to make the RC :) Please make a PR immediately and we can try and get it in. I am unclear about (1) - Can I confirm that users would not see resource: URLs, only developers? I do not think relative paths should produce a warning as th

Re: [Geoserver-devel] Paths utility class

2023-09-13 Thread Niels Charlier via Geoserver-devel
Hello Jody and Gabriel, Sorry for my late response. I have a suggestion to resolve the issue, please let me know what you think, My suggestion is that I would make a pull request with the following proposed changes, and you would review it. 1. The methods Resources.fromPath as well as Resou

[Geoserver-devel] Paths utility class

2023-08-18 Thread Jody Garnett
Niels: I checked if we were having a work party today, and put a little time into the activity. And I finally have a useful answer for you: Why did Resource absolute path change from being relative to the data directory? The answer is ... the concept of a Path was used all over our codebase, wit