Re: [Geoserver-devel] Problem obtaining an SLD from the REST API

2014-03-07 Thread Jody Garnett
That is the one! It should be a lot easier to follow then last time (and you can just email it in). Do keep in mind there is one to bounce off your employer as well. Jody Garnett On Fri, Mar 7, 2014 at 9:28 PM, Nuno Oliveira < nuno-miguel-olive...@telecom.pt> wrote: > Hi Jody, > > Thanks. > >

Re: [Geoserver-devel] Problem obtaining an SLD from the REST API

2014-03-07 Thread Nuno Oliveira
Hi Jody, Thanks. Related to the contribution agreement, I have only signed the geoserver one when I contribute the W3DS module. Since I pretend to become more active in the geoserver\geotools stack (and have other things that maybe interesting to contribute) I definitively should sign the c

Re: [Geoserver-devel] Problem obtaining an SLD from the REST API

2014-03-05 Thread Jody Garnett
Thanks Nuno: Created an Jira issue: https://jira.codehaus.org/browse/GEOT-4726 And have applied the fix to master, 11.x and 10.x Jody Garnett On Thu, Mar 6, 2014 at 1:28 AM, Nuno Oliveira < nuno-miguel-olive...@telecom.pt> wrote: > Hi, > > I just made the pull request for this: > https://git

Re: [Geoserver-devel] Problem obtaining an SLD from the REST API

2014-03-05 Thread Nuno Oliveira
Hi, I just made the pull request for this: https://github.com/geotools/geotools/pull/385 Since we use a lot of other functions in our SLD I keep the OGC expression syntax, it seems more "compatible". By the way, I test the CQL syntax and all seems to work fine ... if I forgot something to

Re: [Geoserver-devel] Problem obtaining an SLD from the REST API

2014-03-04 Thread Andrea Aime
On Tue, Mar 4, 2014 at 4:26 PM, Andrea Aime wrote: > On Tue, Mar 4, 2014 at 3:59 PM, Jody Garnett wrote: > >> The proposal[1] documents the use of ${ cql expression} so your original >> example would be: >> >> ${strToUpperCase('shape')} >> > > Jody, the proposal was implemented so that the syntax

Re: [Geoserver-devel] Problem obtaining an SLD from the REST API

2014-03-04 Thread Andrea Aime
On Tue, Mar 4, 2014 at 5:10 PM, Nuno Oliveira < nuno-miguel-olive...@telecom.pt> wrote: > Thanks Jody and Aime for the explanations, I will proceed with the pull > request. > > By the way ( I know and understand the need to follow with the standards > but, ) when we have a big SLD with complex "b

Re: [Geoserver-devel] Problem obtaining an SLD from the REST API

2014-03-04 Thread Nuno Oliveira
Thanks Jody and Aime for the explanations, I will proceed with the pull request. By the way ( I know and understand the need to follow with the standards but, ) when we have a big SLD with complex "business" based on scales, request attributes , properties ... we often end up with an SLD that

Re: [Geoserver-devel] Problem obtaining an SLD from the REST API

2014-03-04 Thread Andrea Aime
On Tue, Mar 4, 2014 at 3:59 PM, Jody Garnett wrote: > The proposal[1] documents the use of ${ cql expression} so your original > example would be: > > ${strToUpperCase('shape')} > Jody, the proposal was implemented so that the syntax above is used only for external graphics (where we don't have

Re: [Geoserver-devel] Problem obtaining an SLD from the REST API

2014-03-04 Thread Jody Garnett
The proposal[1] documents the use of ${ cql expression} so your original example would be: ${strToUpperCase('shape')} -- Jody [1] http://docs.codehaus.org/display/GEOTOOLS/Dynamic+SLD+Graphic+objects On Wed, Mar 5, 2014 at 1:47 AM, Nuno Oliveira < nuno-miguel-olive...@telecom.pt> wrote: > Hi,

Re: [Geoserver-devel] Problem obtaining an SLD from the REST API

2014-03-04 Thread Nuno Oliveira
Hi, Sorry, I don't understand what you mean by: "I would expect the expression to be encoded as a String with a bit more escaping". Do you agree in having a full encoding of the WellkownName element (i.e. its expression): encodeValue("WellKnownName", null, mark.getWellKnownName(), null)

Re: [Geoserver-devel] Problem obtaining an SLD from the REST API

2014-03-04 Thread Nuno Oliveira
Hi Aime, Thanks for the feedback. I will make a pull request in Geotools and provide a test for this use case. Best regards, Nuno Oliveira On 03/04/2014 02:10 PM, Andrea Aime wrote: On Tue, Mar 4, 2014 at 3:03 PM, Nuno Oliveira > wrote: In my p

Re: [Geoserver-devel] Problem obtaining an SLD from the REST API

2014-03-04 Thread Jody Garnett
I think you have just found a gap from when we extended SLD to support expressions for dynamic marks. Technically SLD should only allow a String for WellKnownName, I would expect the expression to be encoded as a String with a bit more escaping. See: - http://blog.geoserver.org/2008/12/08/dynamic-

Re: [Geoserver-devel] Problem obtaining an SLD from the REST API

2014-03-04 Thread Andrea Aime
On Tue, Mar 4, 2014 at 3:03 PM, Nuno Oliveira < nuno-miguel-olive...@telecom.pt> wrote: > > In my point of view the WellKnownName should have a full conversion, > i.e. instead of: > > element("WellKnownName", mark.getWellKnownName().toString()); > > we should have: > > encodeValue("WellK

[Geoserver-devel] Problem obtaining an SLD from the REST API

2014-03-04 Thread Nuno Oliveira
Hi, When I try to obtain an SLD from GeoServer REST API that have an WellKnownName element that use some ogc:function I don't get the expected result. Lets say I have following SLD: http://www.opengis.net/sld"; xmlns:sld="http://www.opengis.net/sld";