I noticed this block of code:
https://github.com/geoserver/geoserver/blob/master/src/web/demo/src/main/java/org/geoserver/web/catalogstresstool/CatalogStressTester.java#L276-287

(Not because I'm doing a thorough review, it just happens to fail
compilation against Wicket 1.5)

I notice that "startLink" and "progress" are being added to the
AjaxRequestTarget both before the try-block and in its finally clause.
 This seems unnecessary - what's going on there?

While I'm at it, is there a more specific exception type than "Exception"
that we should be catching here?

--
David Winslow
OpenGeo - http://opengeo.org/
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Reply via email to