Re: [Geoserver-devel] oauth2 core

2018-12-07 Thread Thomas
I've added changes to 2.14.x to what is in master. My pull request is at https://github.com/geoserver/geoserver/pull/3289 Cheers ~Thomas On Thu, Dec 6, 2018 at 2:44 PM Andrea Aime wrote: > Yes, that's correct, within the limits of what "being in a release" means > for a community module, since

Re: [Geoserver-devel] oauth2 core

2018-12-06 Thread Andrea Aime
Yes, that's correct, within the limits of what "being in a release" means for a community module, since they are only built along nightly builds, but are not packaged along with official releases. Cheers Andrea Il giorno mer 5 dic 2018, 23:51 Thomas ha scritto: > Does this mean it won't it into

Re: [Geoserver-devel] oauth2 core

2018-12-05 Thread Thomas
Does this mean it won't it into 2.14.3 but will be in the 2.15.0 release in February? On Wed, Dec 5, 2018 at 1:25 PM Andrea Aime wrote: > I have no reason to backport them, they were done for a pilot project that > will never use the stable series. But you can backport, if you want of > course :

Re: [Geoserver-devel] oauth2 core

2018-12-05 Thread Andrea Aime
I have no reason to backport them, they were done for a pilot project that will never use the stable series. But you can backport, if you want of course :-) Cheers Andrea Il giorno mer 5 dic 2018, 18:49 Thomas ha scritto: > I'm working on 2.14.x. The changes haven't made it into there yet. Bu

Re: [Geoserver-devel] oauth2 core

2018-12-05 Thread Thomas
I'm working on 2.14.x. The changes haven't made it into there yet. But I can see they are in master. When might the changes make it into 2.14.x? ~Thomas On Wed, Dec 5, 2018 at 12:24 AM Andrea Aime wrote: > Hi Thomas, > some time ago I added some places extracting the bearer token from the >

Re: [Geoserver-devel] oauth2 core

2018-12-05 Thread Andrea Aime
Hi Thomas, some time ago I added some places extracting the bearer token from the headers, but believe that just landed on the developer branch (aka master). There might be more places that need that, but wondering if you might be looking at a different branch. Mind, pull requests are accepted fir

Re: [Geoserver-devel] oauth2 core

2018-12-05 Thread Alessio Fabiani
Go ahead, I'll review it. Thanks for your contribution. Il giorno mar 4 dic 2018 alle ore 22:47 Thomas ha scritto: > I'm working with integrating my work's oauth service with geoserver. Upon > testing the github extension as well as the oauth2 core, I think I may of > found a bug. > > When a r

[Geoserver-devel] oauth2 core

2018-12-04 Thread Thomas
I'm working with integrating my work's oauth service with geoserver. Upon testing the github extension as well as the oauth2 core, I think I may of found a bug. When a request is made, GeoServerOAuthAuthenticationFilter:doFilter is eventually called. The filter checks the request parameter for