Re: [Geoserver-devel] GSIP 96 - pass down thread locals in thread pools

2013-05-31 Thread Andrea Aime
On Mon, May 27, 2013 at 4:28 PM, Andrea Aime andrea.a...@geo-solutions.itwrote: Hi, following up today's meeting I've put together a quick proposal for the machinery needed to fix http://jira.codehaus.org/browse/GEOS-5370 :

Re: [Geoserver-devel] GSIP 96 - pass down thread locals in thread pools

2013-05-29 Thread Alessio Fabiani
+0 here ... although I understood the issue and the solution, it's not fully clear to me if this is the optimal solution. It should work anyway. A. == GeoServer training in Milan, 6th 7th June 2013! Visit http://geoserver.geo-solutions.it for more information. == Ing. Alessio Fabiani @alfa7691

Re: [Geoserver-devel] GSIP 96 - pass down thread locals in thread pools

2013-05-28 Thread Andrea Aime
On Tue, May 28, 2013 at 6:09 AM, Ben Caradoc-Davies ben.caradoc-dav...@csiro.au wrote: +1. Good analysis of the problem. My one concern is that this change might introduce some interesting new thread-local leaks, either security or plain unanticipated thread interactions. Would you consider

[Geoserver-devel] GSIP 96 - pass down thread locals in thread pools

2013-05-27 Thread Andrea Aime
Hi, following up today's meeting I've put together a quick proposal for the machinery needed to fix http://jira.codehaus.org/browse/GEOS-5370 : http://geoserver.org/display/GEOS/GSIP+96+-+Machinery+to+pass+thread+locals+down+in+thread+pools Feedback and votes welcomed :-) Cheers Andrea -- ==

Re: [Geoserver-devel] GSIP 96 - pass down thread locals in thread pools

2013-05-27 Thread Phil Scadden
+0. While I am all for the bug being fixed, I dont think I can comment usefully on the efficacy of the proposed solution. Notice: This email and any attachments are confidential. If received in error please destroy and immediately notify us. Do not copy or disclose the contents.

Re: [Geoserver-devel] GSIP 96 - pass down thread locals in thread pools

2013-05-27 Thread Justin Deoliveira
Looks good to me. +1 On Mon, May 27, 2013 at 4:37 PM, Phil Scadden p.scad...@gns.cri.nz wrote: +0. While I am all for the bug being fixed, I dont think I can comment usefully on the efficacy of the proposed solution. Notice: This email and any attachments are confidential. If received in

Re: [Geoserver-devel] GSIP 96 - pass down thread locals in thread pools

2013-05-27 Thread Ben Caradoc-Davies
+1. Good analysis of the problem. My one concern is that this change might introduce some interesting new thread-local leaks, either security or plain unanticipated thread interactions. Would you consider leaving this on master for a month before backporting? Kind regards, Ben. On 27/05/13