Re: [Geotools-devel] 2.3-beta1 release train stalled, missing dbconfig

2013-01-23 Thread Jody Garnett
Sorry wrong list (blah) -- Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials b

[Geotools-devel] 2.3-beta1 release train stalled, missing dbconfig

2013-01-23 Thread Jody Garnett
The following is available for manual testing (since yesterday): - http://gridlock.opengeo.org/geoserver/release/2.3-beta1 I did try the publish step, and ran into a helping of build fail: geoserver-release-publish#34 (http://hudson.opengeo.org/hudson/job/geoserver-release-publish/34/console)

[Geotools-devel] GeoTools 8.6 released

2013-01-23 Thread Andrea Aime
The GeoTools community is pleased to announce the availability of GeoTools 8.6 for download from source forge: http://sourceforge.net/projects/geotools/files/GeoTools%208%20Releases/8.6/geotools-8.6-bin.zip/download http://sourceforge.net/projects/geotools/files/GeoTools%208%20Releases/8.6/geotools

Re: [Geotools-devel] including GEOT-4282 in the codebase?

2013-01-23 Thread Ákos Maróy
I've attached a new patch to the ticket, which also includes a test case I've verified it: the test case enters an infinite loop without the fix applied, and it runs fine with the fix applied please consider this to be added to the main codebase of course, all commends, critiques, etc. welcome

Re: [Geotools-devel] including GEOT-4282 in the codebase?

2013-01-23 Thread Michael Bedward
On 23 January 2013 21:12, Andrea Aime wrote: > Daemon threads are known for not blocking the JVM shutdown, however, not > sure if > that holds true also for active ones > Mmm... thought I was doing that in Jiffle with a daemon polling thread. Probably a false memory. Shutdown hooks ? http://stac

Re: [Geotools-devel] including GEOT-4282 in the codebase?

2013-01-23 Thread Andrea Aime
On Wed, Jan 23, 2013 at 11:08 AM, Ákos Maróy wrote: > On 23/01/13 11:01, Michael Bedward wrote: > > Could you make it a daemon thread ? > > > that wouldn't help > > see the details here: > http://docs.oracle.com/javase/7/docs/technotes/guides/concurrency/threadPrimitiveDeprecation.html > > basi

Re: [Geotools-devel] including GEOT-4282 in the codebase?

2013-01-23 Thread Ákos Maróy
On 23/01/13 11:01, Michael Bedward wrote: > Could you make it a daemon thread ? > that wouldn't help see the details here: http://docs.oracle.com/javase/7/docs/technotes/guides/concurrency/threadPrimitiveDeprecation.html basically there is no way to aggressively kill a thread in java

Re: [Geotools-devel] including GEOT-4282 in the codebase?

2013-01-23 Thread Michael Bedward
Could you make it a daemon thread ? Michael On 23 January 2013 20:57, Ákos Maróy wrote: > On 23/01/13 10:34, Andrea Aime wrote: >> >> The thing is, you cannot kill a thread in java, it has to die on its own >> (the method that supposedly does it is deprecated and afaik does nothing). >> >> Norm

Re: [Geotools-devel] including GEOT-4282 in the codebase?

2013-01-23 Thread Ákos Maróy
On 23/01/13 10:34, Andrea Aime wrote: > > The thing is, you cannot kill a thread in java, it has to die on its own > (the method that supposedly does it is deprecated and afaik does nothing). > > Normally this is done by either raising a flag that will make the > code just stop, or by poisoning it

Re: [Geotools-devel] including GEOT-4282 in the codebase?

2013-01-23 Thread Andrea Aime
On Wed, Jan 23, 2013 at 10:32 AM, Michael Bedward wrote: > > Would it be possible to use CountDownLatch.await( timeout ) in the > test case and kill the rendering thread if that returns false ? (I > haven't looked at this issue so that may be off track) > The thing is, you cannot kill a thread

Re: [Geotools-devel] including GEOT-4282 in the codebase?

2013-01-23 Thread Michael Bedward
On 23/01/13 10:06, Andrea Aime wrote: > > Humm... I believe that for this bug there is no way to stop the thread in > case the > bug shows up again. > If so, I would not go for the trouble of setting up a separate thread I > think, just > use the main one, and if the bug shows up again, the build w

Re: [Geotools-devel] including GEOT-4282 in the codebase?

2013-01-23 Thread Andrea Aime
On Wed, Jan 23, 2013 at 10:09 AM, Ákos Maróy wrote: > well, if that's OK with you, makes my life easier. but then again, you > might end up with never-ending jenkins build cycles if the bug shows up > again. > > Fully agree with you it's not good... Hum.. in the separate thread, is there a way t

Re: [Geotools-devel] including GEOT-4282 in the codebase?

2013-01-23 Thread Ákos Maróy
On 23/01/13 10:06, Andrea Aime wrote: > On Wed, Jan 23, 2013 at 10:03 AM, Ákos Maróy > wrote: > >> makes sense. do you have a suggested pattern for including a test >> case for testing for an infinite loop? fire up the process in a >> separate thread & wait for so

Re: [Geotools-devel] including GEOT-4282 in the codebase?

2013-01-23 Thread Andrea Aime
On Wed, Jan 23, 2013 at 10:03 AM, Ákos Maróy wrote: > makes sense. do you have a suggested pattern for including a test case > for testing for an infinite loop? fire up the process in a separate thread > & wait for some time for it to finish? > > Humm... I believe that for this bug there is no w

Re: [Geotools-devel] including GEOT-4282 in the codebase?

2013-01-23 Thread Ákos Maróy
On 23/01/13 10:00, Jody Garnett wrote: > Usual check list, ensure it has a test case, submit JIRA etc… > > Maybe faster, submit pull request (rather than attach patch to the Jira) > > Finally if it is for a deadline, consider hiring one of the groups > offering GeoTools support to get it done promp

Re: [Geotools-devel] including GEOT-4282 in the codebase?

2013-01-23 Thread Jody Garnett
Usual check list, ensure it has a test case, submit JIRA etc… Maybe faster, submit pull request (rather than attach patch to the Jira) Finally if it is for a deadline, consider hiring one of the groups offering GeoTools support to get it done promptly (if not you are basically waiting on a de

[Geotools-devel] including GEOT-4282 in the codebase?

2013-01-23 Thread Ákos Maróy
Hi, I wonder what can I do to have this patch included in the source code base: https://jira.codehaus.org/browse/GEOT-4284 without this patch, infinite loops occur simply by using specific SLDs. best regards, Akos --