Re: [Geotools-devel] [ExternalEmail] Re: LabelShieldTest also failing on Linux with Java 6

Looking at the rendered images suggests that this test is vulnerable to local font configuration. My failing configuration has: $ fc-match serif LiberationSerif-Regular.ttf: "Liberation Serif" "Regular" I created a Jira issue: https://jira.codehaus.org/browse/GEOT-4786 Kind regards, Ben. On 28

[Geotools-devel] [jira] (GEOT-4786) LabelShieldTest depends on local font configuration

Title: Message Title Ben Caradoc-Davies created an issue

Re: [Geotools-devel] [ExternalEmail] Boundless Jenkins hung?

It did pass, but took over an hour. :-| On 28/04/14 10:50, Ben Caradoc-Davies wrote: > Builds do not appear to complete: > http://ares.boundlessgeo.com/jenkins/view/geotools/job/geotools-master/245/ -- Ben Caradoc-Davies Software Engineer CSIRO Earth Science and Resource Engineering Australian

[Geotools-devel] Jenkins build is back to normal : geotools-master #245

See -- "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run your Selenium tests across 300+ browser/OS combos. Get unparalleled

[Geotools-devel] Boundless Jenkins hung?

Builds do not appear to complete: http://ares.boundlessgeo.com/jenkins/view/geotools/job/geotools-master/245/ -- Ben Caradoc-Davies Software Engineer CSIRO Earth Science and Resource Engineering Australian Resources Research Centre ---

[Geotools-devel] Filter clean up pull request 434

I decided to keep Andrea company by working on our technical debt[1] - thanks to GEOT-4785. While my last pull request was interesting, this one is extensive: - https://github.com/geotools/geotools/pull/434 Please see the pull request for full description. While this pull request does not fix ev

Re: [Geotools-devel] LabelShieldTest also failing on Linux with Java 6

Failure started with: 5c9e3f38f3eca2403d284642e8dd2c0418e0d690 "[GEOT-4309] stretch graphic element misplaced around text label (includes an intial 4 line fix by M. Romero, expanded and tested by yours truly)" On 28/04/14 10:09, Ben Caradoc-Davies wrote: > LabelShieldTest is also failing on Li

Re: [Geotools-devel] LabelShieldTest also failing on Linux with Java 6

Ben we were testing LabelShieldTest with a pure java implementation of PerceptualDiff. Looking at the visual comparison this test is very sensitive to different fonts used, as a large box is drawn around the output). Since we are using a generic "serif" font for the test we are ensured different "

[Geotools-devel] LabelShieldTest also failing on Linux with Java 6

LabelShieldTest is also failing on Linux with Java 6. Jody suggested (on IRC) picking a more platform-independent font. Boundless Jenkins looks stuck; I have kicked geotools-master to see if I can get it to reproduce this failure, which I see locally and on another Jenkins. Locally I see: Fail

Re: [Geotools-devel] Label Shield failure with Oracle JDK 7 (OS X)

I a moment, just testing geoserver after blowing away a lot of deprecated org.geotools.filter.Filter methods (see GEOT-4785). Jody Garnett On Sun, Apr 27, 2014 at 7:04 PM, Andrea Aime wrote: > Ah, another thing, > the ImageAssert class is used also in a few GeoServer tests. > > I've already ch

Re: [Geotools-devel] Label Shield failure with Oracle JDK 7 (OS X)

That is the only failure I have. Jody Garnett On Sun, Apr 27, 2014 at 6:21 PM, Andrea Aime wrote: > Hi, > so the windows build also fails here, with 380 and 771 pixels of difference > respectively. > > Instead of starting to set different limits, I'd just raise the limit to > 1200 for both > te

Re: [Geotools-devel] Label Shield failure with Oracle JDK 7 (OS X)

Ah, another thing, the ImageAssert class is used also in a few GeoServer tests. I've already checked Linux, going to build once in Windows, can anybody give it a kick on OSX? Cheers Andrea On Sun, Apr 27, 2014 at 11:03 AM, Andrea Aime wrote: > On Sun, Apr 27, 2014 at 10:21 AM, Andrea Aime <

Re: [Geotools-devel] Label Shield failure with Oracle JDK 7 (OS X)

On Sun, Apr 27, 2014 at 10:21 AM, Andrea Aime wrote: > Hi, > so the windows build also fails here, with 380 and 771 pixels of difference > respectively. > > Instead of starting to set different limits, I'd just raise the limit to > 1200 for both > tests and call it a day. > > The bug that I've fix

Re: [Geotools-devel] Label Shield failure with Oracle JDK 7 (OS X)

Hi, so the windows build also fails here, with 380 and 771 pixels of difference respectively. Instead of starting to set different limits, I'd just raise the limit to 1200 for both tests and call it a day. The bug that I've fixed when that test was created would have created something like 10-20k

Re: [Geotools-devel] Image comparison tests for java 7

On Sat, Apr 26, 2014 at 7:23 PM, Andrea Aime wrote: > Now, under these conditions it's important that stuff works on all > platforms. > Can anybody run the build of the above branch on OSX and Windows, > to see if things build fine there too? > You just need to add my repo as a remote, and fetch i

Re: [Geotools-devel] Upgrading our connection pool library

On Sun, Apr 27, 2014 at 9:38 AM, Jody Garnett wrote: > Well if they are equal, and both require coding to upgrade we may be able > to check what is faster. > Yes, except my intention is asking was to see if anybody already knows or has had experiences with them. I have no mandate to work on a co

Re: [Geotools-devel] Upgrading our connection pool library

Well if they are equal, and both require coding to upgrade we may be able to check what is faster. Jody Garnett On Sun, Apr 27, 2014 at 5:33 PM, Andrea Aime wrote: > Hi, > I was checking the commons-dbcp web site and noticed DBCP 2.0 is out. > While they claim DBCP has higher performance, versi

Re: [Geotools-devel] Label Shield failure with Oracle JDK 7 (OS X)

I would also be happy with a higher threshold, but was not sure if you would be - since often that 1% is what we are actually testing is correct. Still you can use the os and version logic to set this combined with the value from the original email: * testLabelShieldMultiline: 1100 * testLabelShie

[Geotools-devel] Upgrading our connection pool library

Hi, I was checking the commons-dbcp web site and noticed DBCP 2.0 is out. While they claim DBCP has higher performance, version 2.0 is not binary compatible with the 1.x series (and it requires Java 7, no big deal here). Since an upgrade would take some coding, I'm wondering about switching to the

Re: [Geotools-devel] Label Shield failure with Oracle JDK 7 (OS X)

On Sun, Apr 27, 2014 at 8:39 AM, Jody Garnett wrote: > 4) OSX 10.9 Reference Images > > Since this is a known JDK bug I do not want to put a great deal of effort > into a workaround, I recommend carrying additional "osx" references images > in or codebase until it is resolved. > > I was unable to

Re: [Geotools-devel] JPEG related failure under openjdk 7

On Sun, Apr 27, 2014 at 8:57 AM, Jody Garnett wrote: > Was thinking you were focused on comparing images ... in which case it > would be nice to avoid writing files. But it looks like you have moved on > to further testing. > Nope, I have started a separate thread for this one because the failure