Re: [Geotools-devel] Discussing fix for issue GEOT-4885

On Wed, Feb 11, 2015 at 11:43 PM, Stefano Costa wrote: > > > ...and now I see a flood of exceptions in the log, but rendering never > stops! :-) > And keeps on reporting errors in a continous stream? Either it's stuck or there is a whole lot of them. > > Anyway, the person who reported the issu

Re: [Geotools-devel] Pull request for WFS-NG

Hi, Thanks for the feedback. I've updated the headers. Sampo On Wed, Feb 11, 2015 at 4:59 PM, Jody Garnett wrote: > Thanks Sampo. > > Some small feedback (headers) but otherwise this looks good to go. > > -- > Jody Garnett > > On 11 February 2015 at 04:59, Sampo Savolainen < > sampo.savolai.

Re: [Geotools-devel] Discussing fix for issue GEOT-4885

Hi all, thanks Andrea and Jody for your comments. Andrea, no, I'm not getting more than 1000 failures, nor I'm the rendering is taking more than 60 seconds, but *you're absolutely right: StreamingRenderer is indeed already lenient on errors*, as you explained. I overlooked the fireErrorEvent() met

Re: [Geotools-devel] Discussing fix for issue GEOT-4885

Hi Stefano, sorry for the late reply, I'm stll stuck in bed with fever... Anyways, the streaming renderer is built to be tolerant to errors, the code looks as follows: try { painter.paint(graphic, shape, style, scale, labelObstacle); } catch(Throwable t) {

Re: [Geotools-devel] Discussing fix for issue GEOT-4885

I kind of like your approach Stefano, I am fond of graceful failure. Right now we fail so we can report an error. As long as your patch logs the featureId with the problem for the sys admin to see we are probably good (perhaps at level FINE). You consider turning this on with a query hint along th

[Geotools-devel] Discussing fix for issue GEOT-4885

Dear GeoTools developers, I'm attempting to tackle issue GEOT-4885: GeoTools stops rendering valid geometry elements after an invalid geometry element and, since I'm pretty much a newbie here, I need guidance as to how to solve it sensibly. The issue rep

Re: [Geotools-devel] Pull request for WFS-NG

Thanks Sampo. Some small feedback (headers) but otherwise this looks good to go. -- Jody Garnett On 11 February 2015 at 04:59, Sampo Savolainen < sampo.savolai...@spatineo.com> wrote: > Hi, > > I just submitted a small pull request on WFS-NG and Cascaded Stored > Queries as discussed on geoserv

[Geotools-devel] Pull request for WFS-NG

Hi, I just submitted a small pull request on WFS-NG and Cascaded Stored Queries as discussed on geoserver-devel. https://github.com/geotools/geotools/pull/730 In addition to removing unnecessary code (an overridden CQL + operator), this also fixes a real issue in Cascaded Stored Query support th