Re: [Geotools-devel] Move DataUtilities URL methods to new URLs class in gt-metadata [GEOT-5740]

2017-05-30 Thread Ben Caradoc-Davies
Thanks, everyone. Opinion was evenly divided. After much discussion, including on Gitter , the new class is called "URLs". Pull request updated and merged on master. Kind regards, Ben. On 30/05/17 17:15,

Re: [Geotools-devel] upgrade postgresql JDBC driver to 42.1.1 (full binary xfer)

2017-05-30 Thread Ben Caradoc-Davies
Thanks, Dave. That is a good point. I think 8.2 came out in 2006 or so. Last release for 8.1 was in 2010. Developers, are we happy to drop support for PostgreSQL below 8.2? Kind regards, Ben. On 31/05/17 05:43, Dave Blasby wrote: Hi, Ben, Thanks for putting the PR together and making sure ev

Re: [Geotools-devel] A few changes coming to the CSS module (and then its graduation)

2017-05-30 Thread Andrea Aime
On Sun, May 28, 2017 at 10:30 PM, Ben Caradoc-Davies wrote: > If you want SI then it should be "k" and "M" and "G". Personally I find > lowercase to be more readable. I say accept both, but then I also prefer > 1e10. :-) > Hum... and G would be useful for scale dependencies on a map of... Jupit

Re: [Geotools-devel] [Geoserver-devel] upgrade postgresql JDBC driver to 42.1.1 (full binary xfer)

2017-05-30 Thread Dave Blasby
Hi, Andrea, if you aren't using prepared statements, it doesn't know that the data is binary and it will "kick back" to the standard encoding (with a lot of "\001"-like in the text). It will work, but you are at approximately 300% overhead. As mentioned, above, I believe it works for PostgreSQL

Re: [Geotools-devel] [Geoserver-devel] upgrade postgresql JDBC driver to 42.1.1 (full binary xfer)

2017-05-30 Thread Andrea Aime
On Tue, May 30, 2017 at 7:01 PM, Dave Blasby wrote: > Hi, Andrea, > > Only updating the driver version. > > I can work with the PostGIS maintainer to get it in - it's fairly easy > (just need to ensure that you are using prepared statements). > Maintainer eh? It used to be me and Justin. When yo

Re: [Geotools-devel] upgrade postgresql JDBC driver to 42.1.1 (full binary xfer)

2017-05-30 Thread Dave Blasby
Hi, Ben, Thanks for putting the PR together and making sure everything was tested (esp online tests). WRT postgresql version support, I found this in the release notes for 42.0.0; - Support for PostgreSQL versions below 8.2 was dropped Thanks, Dave On Mon, May 29, 2017 at 8:31 PM, Ben Car

Re: [Geotools-devel] [Geoserver-devel] upgrade postgresql JDBC driver to 42.1.1 (full binary xfer)

2017-05-30 Thread Dave Blasby
Hi, Andrea, Only updating the driver version. I can work with the PostGIS maintainer to get it in - it's fairly easy (just need to ensure that you are using prepared statements). The difficulty is in verifying it's working - you don't really have any access to what's happening in the driver. Fo

[Geotools-devel] GeoTools / GeoWebCache / GeoServer Meeting 2017-05-30

2017-05-30 Thread Torben Barsballe
Attending Andrea Aime Ian Turton Jody Garnett Jukka Rahkonen Kevin Smith Torben Barsballe Agenda - CalGIS Workshop retrospective - Better description for community modules - Chit Chat Action items - AA: make a GSIP to get some more information out of developers

Re: [Geotools-devel] MetaDataProperty attribute?

2017-05-30 Thread Ian Turton
PR is at https://github.com/geoserver/geoserver/pull/2375 Ian On 30 May 2017 at 15:42, Andrea Aime wrote: > On Tue, May 30, 2017 at 4:25 PM, Ian Turton wrote: > >> Yes, it occurs in DataUtilities and >> >> // HACK HACK!! the parser sets no namespace to the properties so we're >> // doi

Re: [Geotools-devel] Move DataUtilities URL methods to new Urls class in gt-metadata [GEOT-5740]

2017-05-30 Thread Andrea Aime
Ah ok, I thought you were discussing a library wide change Cheers Andrea On Tue, May 30, 2017 at 4:52 PM, Jody Garnett wrote: > In this case Ben is trying to remove duplicate code that is currently in > gt-referencing and gt-main into a common class. (So this is being done for > code maintenanc

Re: [Geotools-devel] Move DataUtilities URL methods to new Urls class in gt-metadata [GEOT-5740]

2017-05-30 Thread Jody Garnett
In this case Ben is trying to remove duplicate code that is currently in gt-referencing and gt-main into a common class. (So this is being done for code maintenance rather than change for changes sake). -- Jody Garnett On 30 May 2017 at 00:37, Andrea Aime wrote: > And I'd say "don't touch" :-)

Re: [Geotools-devel] MetaDataProperty attribute?

2017-05-30 Thread Andrea Aime
On Tue, May 30, 2017 at 4:25 PM, Ian Turton wrote: > Yes, it occurs in DataUtilities and > > // HACK HACK!! the parser sets no namespace to the properties so we're > // doing a hardcode property name black list > final Set ignoreList = new HashSet(Arrays.asList(new > String[] { >

[Geotools-devel] [JIRA] (GEOT-5743) Error in CSV2SHP tutorial

2017-05-30 Thread John Jesus (JIRA)
Title: Message Title John Jesus created an

Re: [Geotools-devel] MetaDataProperty attribute?

2017-05-30 Thread Ian Turton
Found it - a type in WFSPIPO, it was looking for metadataProperty instead of metaDataProperty I'll file a bug and PR Ian On 30 May 2017 at 15:25, Ian Turton wrote: > Yes, it occurs in DataUtilities and > > // HACK HACK!! the parser sets no namespace to the properties so we're > // doin

Re: [Geotools-devel] MetaDataProperty attribute?

2017-05-30 Thread Ian Turton
Yes, it occurs in DataUtilities and // HACK HACK!! the parser sets no namespace to the properties so we're // doing a hardcode property name black list final Set ignoreList = new HashSet(Arrays.asList(new String[] { GML.location.getLocalPart(), GML.metaDataProperty.

Re: [Geotools-devel] MetaDataProperty attribute?

2017-05-30 Thread Andrea Aime
Hi Ian, is that block the one in DataUtiltities,simple(FeatureType) ? As far as I can tell it's related to GML parsing or something like that Cheers Andrea On Tue, May 30, 2017 at 3:52 PM, Ian Turton wrote: > I'm running into an issue with a WPS process which won't write to a > Shapefile becau

Re: [Geotools-devel] MetaDataProperty attribute?

2017-05-30 Thread Ian Turton
curses, pushed tab/enter too soon! On 30 May 2017 at 14:52, Ian Turton wrote: > I'm running into an issue with a WPS process which won't write to a > Shapefile because: > > java.io.IOException: Unable to write column metaDataPr : java.lang.Object > > Now I don't have any attributes called MetaDa

[Geotools-devel] MetaDataProperty attribute?

2017-05-30 Thread Ian Turton
I'm running into an issue with a WPS process which won't write to a Shapefile because: java.io.IOException: Unable to write column metaDataPr : java.lang.Object Now I don't have any attributes called MetaDataPr but searching the code base turns up a bunch of blocks like: // HACK HACK!! the parse

Re: [Geotools-devel] Move DataUtilities URL methods to new Urls class in gt-metadata [GEOT-5740]

2017-05-30 Thread Justin Deoliveira
I would prefer Urls, think it reads nicer. $0.02 On Tue, May 30, 2017 at 1:38 AM Andrea Aime wrote: > And I'd say "don't touch" :-) (take it as a -0) > I agree common conventions is good. And agree that we might want to set > one convention from here onwards. > But can we please do it without br

[Geotools-devel] [JIRA] (GEOT-5742) Allow mosaic to pick the index DataStore/DataAccess from a Repository instance

2017-05-30 Thread aaime (JIRA)
Title: Message Title aaime created an issu

Re: [Geotools-devel] [Geoserver-devel] upgrade postgresql JDBC driver to 42.1.1 (full binary xfer)

2017-05-30 Thread Andrea Aime
So, are you proposing just an upgrade of the driver, or are you also going to change the postgis store code to leverage the binary transfer? Cheers Andrea On Mon, May 29, 2017 at 11:22 PM, Dave Blasby wrote: > Hi, > > For GeoGig, we noticed that the latest Postgresql JDBC driver (42.1.1) now >

Re: [Geotools-devel] Move DataUtilities URL methods to new Urls class in gt-metadata [GEOT-5740]

2017-05-30 Thread Andrea Aime
And I'd say "don't touch" :-) (take it as a -0) I agree common conventions is good. And agree that we might want to set one convention from here onwards. But can we please do it without breaking backwards compatibility (or possibly generating a lot of deprecated methods?). I'd suggest to put effor