Thanks for the explanation! I know how tricky things like that can be from
other projects. Are there instructions on how to test local changes to
GeoTools with GeoWebCache and GeoServer?
On Tue, Nov 6, 2018 at 9:31 AM Andrea Aime
wrote:
> Hi Kurt,
> thanks for letting us know. PR review is not
Hi Kurt,
thanks for letting us know. PR review is not a sponsored activity and
normally is taken care of
by volunteers during their spare time. Even if the PR looks good by itself,
we need to verify that
it won't break the build in GeoWebCache and GeoServer, two downstream
projects linked to
GeoToo
Hi all,
Is there a chance to get #2129 in? I've rebased: the tests all now pass
and I have what I think are pretty good test coverage.
https://github.com/geotools/geotools/pull/2129
Thanks!
-kurt
___
GeoTools-Devel mailing list
GeoTools-Devel@lists.so
The JIRA ticket is important for it to get into the release notes. Its not
hard to create one. It would have been good practice to include the analysis
in the ticket (which is less likely to get lost than an email discussion).
It probably isn't absolutely critical, but why not do it?
You probably
On Tue, Nov 6, 2018 at 11:23 AM Martin Zeller wrote:
> The reason of the problem is some previously forgotten code - a simple
> .append(" ")
> So I think we don't need a JIRA ticket for this. Would a simple pull
> request be ok?
>
> On the other side the JDBCDataStore has a lot of protected metho
The reason of the problem is some previously forgotten code - a simple
.append(" ")
So I think we don't need a JIRA ticket for this. Would a simple pull
request be ok?
On the other side the JDBCDataStore has a lot of protected methods for
sql generation which cannot be tested easily - like the
There is a developers' guide for GeoTools, and you can read a relevant part
at http://docs.geotools.org/latest/developer/procedures/contribute.html
Please let us know if anything is unclear after you've read through the
guide.
Brad
-Original Message-
From: Martin Zeller
Sent: Tuesday,
