[Geotools-devel] Pre-release GeoTools 23.1 artifacts available for testing

2020-05-30 Thread Jody Garnett
GeoTools 23.1 release process has started, pre-release artifacts / notes are available here: - https://build.geoserver.org/job/geotools-release/8/artifact/build/release/distribution/23.1/ - https://osgeo-org.atlassian.net/secure/ReleaseNote.jspa?projectId=10001&version=16784 We are including the

Re: [Geotools-devel] Best practice for code updates

2020-05-30 Thread Jody Garnett
As module maintainer you get to choose. I have found it easier for reviewers to do several small pull requests. You can see on my most recent mbstyle PR I failed at keeping changes on topic, slowing the review process down with javadoc clarifications and changing variable names to be consistent. -

Re: [Geotools-devel] Best practice for code updates

2020-05-30 Thread Andrea Aime
Hi David, the checklist contained in the PR template covers it, quoting: "The pull request contains changes related to a single objective. If multiple focuses cannot be avoided, each one is in its own commit and has a separate ticket describing it." Full checklist here: https://github.com/geotool

Re: [Geotools-devel] Full bounding box queries

2020-05-30 Thread Jody Garnett
I am not sure I understand, A little greater than the data bounding box - can you provide more information? How does it behave if you zoom out further still? The DB2 code should get a filter and be able to do whatever processing it needs to in order to make a useful query. Many datastore use a vi

Re: [Geotools-devel] Full bounding box queries

2020-05-30 Thread Andrea Aime
Hi David, yes, the behavior is the one expected, a database should be able to fend off by itself in that case, in other words: - Recognize the bbox filter is not selective, and opting for a full table scan - Since all that is requested here is a bbox vs bbox filter, have a way to run t

[Geotools-devel] Full bounding box queries

2020-05-30 Thread David Adler
When using the GeoTools tutorial sample to display a map, modified for DB2, the query generated creates a filter a little greater than the data bounding box. This is time-consuming to process, checking if each feature is within the query area where a straight table-scan of all the data would be

[Geotools-devel] Best practice for code updates

2020-05-30 Thread David Adler
As it has been a while since the DB2 plugin has been updated, there is some code that is obsolete and there is some code that could be optimized. Is it better to do this in several small pull requests or to lump them together? -- This email has been checked for viruses by Avast antivirus sof