Re: [Geotools-devel] Automated code formatting

2006-06-20 Thread Andrea Aime
Chris Holmes ha scritto: > Cool. I think the answer is that the general recommendation should be > that code formatting is used. If a module maintainer feels strongly > against it, they can turn it off on their module and not let people code. > > I do think autoformatting may be lead to some p

Re: [Geotools-devel] Automated code formatting

2006-06-20 Thread Chris Holmes
Cool. I think the answer is that the general recommendation should be that code formatting is used. If a module maintainer feels strongly against it, they can turn it off on their module and not let people code. I do think autoformatting may be lead to some pain initially (though only becaus

Re: [Geotools-devel] Automated code formatting

2006-06-20 Thread Brent Owens
I'm not against adding in jalopy to to make the merger's happen easier, and for future mergers to be easier as well. I just wanted to bring up that there was opposition and it should be taken into consideration. Brent Owens (The Open Planning Project) Andrea Aime wrote: > Brent Owens ha scrit

Re: [Geotools-devel] Automated code formatting + coverage branch merge

2006-06-20 Thread Andrea Aime
Martin Desruisseaux ha scritto: > Andrea Aime a écrit : >> Brent Owens ha scritto: >>> I thought this was already discussed and voted down? Actual changes >>> before this event will be lost in the formatting changes, and that >>> was the main reason for no auto-formatting. >> >> What? No, exactl

Re: [Geotools-devel] Automated code formatting + coverage branch merge

2006-06-20 Thread Martin Desruisseaux
Andrea Aime a écrit : > Brent Owens ha scritto: >> I thought this was already discussed and voted down? >> Actual changes before this event will be lost in the formatting >> changes, and that was the main reason for no auto-formatting. > > What? No, exactly the opposite. I can understand both

Re: [Geotools-devel] Automated code formatting

2006-06-20 Thread Andrea Aime
Brent Owens ha scritto: > I thought this was already discussed and voted down? Hum, if you refer to http://www.nabble.com/Code-Formatting---Vote-t1278276.html#a3414679 it seems to me most of the people was in favour, with a strong opposition from David (based on the fact that it makes branch mer

Re: [Geotools-devel] Automated code formatting

2006-06-19 Thread Brent Owens
I thought this was already discussed and voted down? Actual changes before this event will be lost in the formatting changes, and that was the main reason for no auto-formatting. That and it will never please everyone: we all have our own styles. Would it be an option to format locally and then

Re: [Geotools-devel] Automated code formatting

2006-06-19 Thread Andrea Aime
Andrea Aime ha scritto: > Hi Martin, > I'm writing you because tonight we discussed again automated code > formatting. The meeting logs are here: http://docs.codehaus.org/display/GEOTOOLS/2006/06/19 (thank you Chris for posting them! :-) ) Cheers Andrea

[Geotools-devel] Automated code formatting

2006-06-19 Thread Andrea Aime
Hi Martin, I'm writing you because tonight we discussed again automated code formatting. Facts: * almost everybody uses some kind of automated formatting from its IDE (you're the only one I know of that still formats the code by hand) * nobody uses exactly the same formatting style (I, for exam