As module maintainer you get to choose. I have found it easier for
reviewers to do several small pull requests.
You can see on my most recent mbstyle PR I failed at keeping changes on
topic, slowing the review process down with javadoc clarifications and
changing variable names to be consistent.
-
Hi David,
the checklist contained in the PR template covers it, quoting:
"The pull request contains changes related to a single objective. If
multiple focuses cannot be avoided, each one is in its own commit and has a
separate ticket describing it."
Full checklist here:
https://github.com/geotool
As it has been a while since the DB2 plugin has been updated, there is
some code that is obsolete and there is some code that could be optimized.
Is it better to do this in several small pull requests or to lump them
together?
--
This email has been checked for viruses by Avast antivirus sof
