Re: [Geotools-devel] Duplicating stuff

2005-12-08 Thread Jody Garnett
Jesse Eichar wrote: Ok good points. But in order to have a useful interface I think we will have to specify the equals methods. I believe, but you can correct me if I'm wrong, that .equals is frequently used. Yep - and we do implement the mojo of Filter.ALL and Filter.NONE to be okay.. But y

Re: [Geotools-devel] Duplicating stuff

2005-12-08 Thread Jesse Eichar
Ok good points. But in order to have a useful interface I think we will have to specify the equals methods. I believe, but you can correct me if I'm wrong, that .equals is frequently used. Jesse Martin Desruisseaux wrote: Jesse Eichar a écrit : I agree with you for the most part Martin.

Re: [Geotools-devel] Duplicating stuff

2005-12-08 Thread Martin Desruisseaux
Jesse Eichar a écrit : I agree with you for the most part Martin. But if you look at some implementations of equals, such as java.util.AbstractList, you will find that it checks only that the object implements the interface and only uses public methods to determine equality. Yes, but they ca

Re: [Geotools-devel] Duplicating stuff

2005-12-08 Thread Jody Garnett
Jesse Eichar wrote: I agree with you for the most part Martin. But if you look at some implementations of equals, such as java.util.AbstractList, you will find that it checks only that the object implements the interface and only uses public methods to determine equality. Because only the in

Re: [Geotools-devel] Duplicating stuff

2005-12-08 Thread Jesse Eichar
I agree with you for the most part Martin. But if you look at some implementations of equals, such as java.util.AbstractList, you will find that it checks only that the object implements the interface and only uses public methods to determine equality. Because only the interface methods are u

Re: [Geotools-devel] Duplicating stuff

2005-12-07 Thread Martin Desruisseaux
Justin Deoliveira a écrit : I had a look at some of the style model objects implementations. I notice the equals() methods all look for an instance of the same Impl class, and not of the actual interface. For example FillImpl: [...snip...] Isn't this a problem? If someone comes along with th

Re: [Geotools-devel] Duplicating stuff

2005-12-07 Thread Jody Garnett
Justin Deoliveira wrote: I had a look at some of the style model objects implementations. I notice the equals() methods all look for an instance of the same Impl class, and not of the actual interface. For example FillImpl: public boolean equals(Object oth) { if (this == oth) {

Re: [Geotools-devel] Duplicating stuff

2005-12-07 Thread Justin Deoliveira
I had a look at some of the style model objects implementations. I notice the equals() methods all look for an instance of the same Impl class, and not of the actual interface. For example FillImpl: public boolean equals(Object oth) { if (this == oth) { return true;

Re: [Geotools-devel] Duplicating stuff

2005-12-07 Thread Jody Garnett
Jody Garnett wrote: I do not see facilities in the toolkit for duplicating Filter / Expression / Style. I am finding some errors in the test cases as bad assumptions are made about Symbolizer reuse Found a scary example of Styles being cloned in a test case: Style clone = (Style) ((Clonea

[Geotools-devel] Duplicating stuff

2005-12-07 Thread Jody Garnett
I do not see facilities in the toolkit for duplicating Filter / Expression / Style. I am finding some errors in the test cases as bad assumptions are made about Symbolizer reuse More hack lest chat ... Jody --- This SF.net email is spo