Re: [Geotools-devel] Excessive method length code smell

2021-03-10 Thread Andrea Aime
On Wed, Mar 10, 2021 at 4:34 PM Gabriel Roldan wrote: > Yeah, 500 sounded like a stupidly high limit, sounds like a good one to > start with, with 4 offenders per project. > Ah yeah sorry... I quickly scanned through the thread and missed the report (I don't really read mails anymore, just glanc

Re: [Geotools-devel] Excessive method length code smell

2021-03-10 Thread Gabriel Roldan
Hey Andrea, On Wed, 10 Mar 2021 at 12:02, Andrea Aime wrote: > Hi Gabriel, > I would love to see having a limit on the method length... but remember > when running these QAs you're pretty much alone > (as I've been for most of the QA work, even when other people > participated, I ended up doing

Re: [Geotools-devel] Excessive method length code smell

2021-03-10 Thread Andrea Aime
Hi Gabriel, I would love to see having a limit on the method length... but remember when running these QAs you're pretty much alone (as I've been for most of the QA work, even when other people participated, I ended up doing well over 90% of the job). I would suggest you start with a very high lim

Re: [Geotools-devel] Excessive method length code smell

2021-03-10 Thread Gabriel Roldan
Hi Joseph, I'm not sure there's anything that specific, but not an expert either. There are a number of design checks though[1], maybe you want to explore a little bit. Trying to be too strict will get us in trouble, for example, if we wanted to honor the LawOfDemeter one. To be clear, I'm not ad

Re: [Geotools-devel] Excessive method length code smell

2021-03-10 Thread Joseph Miller
I think ExcessiveMethodLength is an important check for the readability and maintainability for code. Is the opposite check also available? Something that would flag too much abstraction and/or too much inheritance or too many interfaces, leading to confusing, unreadable empty methods and classes

[Geotools-devel] Excessive method length code smell

2021-03-10 Thread Gabriel Roldan
Hey all, sorry for cross-posting but this relates to both projects. One of the PMD rules I'd like to set up the most is ExcessiveMEthodLength. It'll just fail on a threshold for lines of code in a single method. I've made some assessments for 500 and 100 lines of code limits, check this out: Geo