To start: MeshSmooth contains a:
enum SmoothType {
LAPLACEAREA
}
Anyone mind if I turn these into codelists so we can compile on Java 1.4.
Initial feedback is pretty good :-) Just grabbing Martin to look over
things as well.
A couple of questions;
- FeatGeomFactoryImpl is basically running as a small container specific
to the problem of producing Geometries. While I cannot see this *used*
anywhere in the codebase it is important to note that this is not a
Factory as it stands now... Shall I assume that the code you are using
this implementation with makes use of this class .. and treat the
problem as a feature request?
- Assert - looks like you have a design decision to make here?
- DoubleOperation vs ExactDouble - if you need this kind of control it
is something we can do library wide
- org.geotools.geometry.iso.util.quadtree - sounds like you guys are
breaking out your own code for heavy lifting?
My other comment is that:
- the comments are verbose, plentiful and possibly duplicate the GeoAPI
documentation?
- While I can find a few non-english comments around at this statge
they tend to add spice.
- Headers, (c) and license are all topics for another day.
More later :-)
Jody
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
