Revised pull request:
https://github.com/geotools/geotools/pull/836
--
Jody Garnett
On 10 May 2015 at 07:06, Jody Garnett wrote:
> I apologize for the misunderstanding, and am going over your feedback as
> we speak. This was also a bit of a group effort with work being revised
> based on publi
I apologize for the misunderstanding, and am going over your feedback as we
speak. This was also a bit of a group effort with work being revised based
on public Jim's feedback, which caught earlier inconsistencies and mistakes.
I will issue a pull request for the changes shortly.
--
Jody Garne
On Sun, May 10, 2015 at 3:37 PM, Jody Garnett
wrote:
> Sorry Andrea I thought your comments on the pull request and subsequent
> email *was* a review :(
>
One commit to help the build going and a mail asking for help because
GeoServer was not building hardly makes
for a review... seems unlikely
Sorry Andrea I thought your comments on the pull request and subsequent
email *was* a review :(
I squashed *some* of the commits (as Jim had some history to clean up).
--
Jody Garnett
On 10 May 2015 at 01:39, Andrea Aime wrote:
> Hi,
> I've noticed the matrix branch has been merged on master a
Hi,
I've noticed the matrix branch has been merged on master as is,
without squashing commits, and without a review.
That's rather uncommon (if not unique for something a proposal based
set of changes), and I still believe a review is important, so I'm going
to do one, please treat it as if it was
