Re: [Geotools-devel] Patch to support useExisting feature insertion mode

2010-05-23 Thread Andrea Aime
Jody Garnett ha scritto: > I was more meaning that I updated that page with your change in mind. > Please review. Looks good, did just some minor edits. Aside... this style of coding: if(...) { ... } else { } is afaik against the Java coding conventions, that do suggest this instead: if(..

Re: [Geotools-devel] Patch to support useExisting feature insertion mode

2010-05-23 Thread Jody Garnett
I was more meaning that I updated that page with your change in mind. Please review. Sphinx is not going to be used until we have a plan and a talk with frank or Justin about deployment. Until then the wiki us our docs. Jody On 23/05/2010, at 6:22 PM, Andrea Aime wrote: > Jody Garnett ha

Re: [Geotools-devel] Patch to support useExisting feature insertion mode

2010-05-23 Thread Andrea Aime
Jody Garnett ha scritto: > Wow that is a lot of work. A lot of work? ... not really, the non bug fix patches I've been committing recently were easily 5-10 times bigger. Or you mean a lot of work on the user part? > So you are needing to set the hint on a > feature by feature basis - suspect we

Re: [Geotools-devel] Patch to support useExisting feature insertion mode

2010-05-22 Thread Jody Garnett
Wow that is a lot of work. So you are needing to set the hint on a feature by feature basis - suspect we have completely given up on Transaction for hint purposes? You have not made an api change so committing to 2.6.x seems reasonable. Proposals work best when you don't have an implementation r

[Geotools-devel] Patch to support useExisting feature insertion mode

2010-05-22 Thread Andrea Aime
Hi, some time ago we started a discussion on how to support the ability to insert a feature with FeatureStore.addFeatures so that the feature id is used as is in the underlying storage instead of being generated. Today I cooked a little patch that enables the above in all JDBC data stores and in