Re: [Geotools-devel] Problem with commit for GEOT-6034

2018-11-12 Thread Nuno Oliveira
Dear all, My apologies for the late catch up, very busy times ...  I'm the one that introduced that bug :( I created an issue for this: * https://github.com/geotools/geotools/pull/2170 Pull requests for this (the master PR lists \ shows the failing Oracle online tests): * https://github.com/geotool

Re: [Geotools-devel] Problem with commit for GEOT-6034

2018-11-06 Thread bradh
es are crazy). Brad -Original Message- From: Martin Zeller Sent: Tuesday, 6 November 2018 9:21 PM To: geotools-devel@lists.sourceforge.net Subject: Re: [Geotools-devel] Problem with commit for GEOT-6034 The reason of the problem is some previously forgotten code - a simple .append(" &q

Re: [Geotools-devel] Problem with commit for GEOT-6034

2018-11-06 Thread Andrea Aime
On Tue, Nov 6, 2018 at 11:23 AM Martin Zeller wrote: > The reason of the problem is some previously forgotten code - a simple > .append(" ") > So I think we don't need a JIRA ticket for this. Would a simple pull > request be ok? > > On the other side the JDBCDataStore has a lot of protected metho

Re: [Geotools-devel] Problem with commit for GEOT-6034

2018-11-06 Thread Martin Zeller
The reason of the problem is some previously forgotten code - a simple .append(" ") So I think we don't need a JIRA ticket for this. Would a simple pull request be ok? On the other side the JDBCDataStore has a lot of protected methods for sql generation which cannot be tested easily - like the

Re: [Geotools-devel] Problem with commit for GEOT-6034

2018-11-06 Thread bradh
t: Tuesday, 6 November 2018 6:34 PM To: geotools-devel@lists.sourceforge.net Subject: Re: [Geotools-devel] Problem with commit for GEOT-6034 On 31.10.2018 08:36, Martin Zeller wrote: > I found a small but important problem with a commit for GEOT-6034: > https://github.com/geotools

Re: [Geotools-devel] Problem with commit for GEOT-6034

2018-11-05 Thread Martin Zeller
On 31.10.2018 08:36, Martin Zeller wrote: I found a small but important problem with a commit for GEOT-6034: https://github.com/geotools/geotools/commit/b11d0e97ef56f3afe1759a6099628851db3db5f7 with this diff: https://github.com/geotools/geotools/commit/b11d0e97ef56f3afe1759a6099628851db3db5f7

[Geotools-devel] Problem with commit for GEOT-6034

2018-10-31 Thread Martin Zeller
I found a small but important problem with a commit for GEOT-6034: https://github.com/geotools/geotools/commit/b11d0e97ef56f3afe1759a6099628851db3db5f7 with this diff: https://github.com/geotools/geotools/commit/b11d0e97ef56f3afe1759a6099628851db3db5f7#diff-3f08f2af86593cd27baeb630bf1b1869L37