Re: [Geotools-devel] Pull request for WFS-NG

2015-02-19 Thread Ben Caradoc-Davies
No problem. I saw your comment on the PR a couple of days ago but did not appreciate its significance. Thanks for bringing it to our attention. Kind regards, Ben. On 20/02/15 08:42, Sampo Savolainen wrote: > Hi, > > Thanks! Sorry about not bringing this up yesterday. > > > Sampo > > On Thu, Fe

Re: [Geotools-devel] Pull request for WFS-NG

2015-02-19 Thread Sampo Savolainen
Hi, Thanks! Sorry about not bringing this up yesterday. Sampo On Thu, Feb 19, 2015 at 9:35 PM, Ben Caradoc-Davies wrote: > Sampo, > > Jody has applied your changes to master. If testing passes, I will apply > them to 13.x and include them in 13-RC1. > > Kind regards, > Ben. > > > On 20/02/15

Re: [Geotools-devel] Pull request for WFS-NG

2015-02-19 Thread Ben Caradoc-Davies
Sampo, Jody has applied your changes to master. If testing passes, I will apply them to 13.x and include them in 13-RC1. Kind regards, Ben. On 20/02/15 07:58, Ben Caradoc-Davies wrote: > Sampo, > > as far as I can tell, your PR has not been merged. > > Jody, does this block RC1? > > Kind regard

Re: [Geotools-devel] Pull request for WFS-NG

2015-02-19 Thread Ben Caradoc-Davies
Sampo, as far as I can tell, your PR has not been merged. Jody, does this block RC1? Kind regards, Ben. On 20/02/15 04:37, Sampo Savolainen wrote: > Hi, > > I haven't received news on this PR. Has this been merged? It would be > really important to have this in RC1 as without it, the cascaded s

Re: [Geotools-devel] Pull request for WFS-NG

2015-02-19 Thread Sampo Savolainen
Hi, I haven't received news on this PR. Has this been merged? It would be really important to have this in RC1 as without it, the cascaded stored queries are essentially broken. Sampo On Thu, Feb 12, 2015 at 8:45 AM, Sampo Savolainen < sampo.savolai...@spatineo.com> wrote: > Hi, > > Thanks fo

Re: [Geotools-devel] Pull request for WFS-NG

2015-02-11 Thread Sampo Savolainen
Hi, Thanks for the feedback. I've updated the headers. Sampo On Wed, Feb 11, 2015 at 4:59 PM, Jody Garnett wrote: > Thanks Sampo. > > Some small feedback (headers) but otherwise this looks good to go. > > -- > Jody Garnett > > On 11 February 2015 at 04:59, Sampo Savolainen < > sampo.savolai.

Re: [Geotools-devel] Pull request for WFS-NG

2015-02-11 Thread Jody Garnett
Thanks Sampo. Some small feedback (headers) but otherwise this looks good to go. -- Jody Garnett On 11 February 2015 at 04:59, Sampo Savolainen < sampo.savolai...@spatineo.com> wrote: > Hi, > > I just submitted a small pull request on WFS-NG and Cascaded Stored > Queries as discussed on geoserv

[Geotools-devel] Pull request for WFS-NG

2015-02-11 Thread Sampo Savolainen
Hi, I just submitted a small pull request on WFS-NG and Cascaded Stored Queries as discussed on geoserver-devel. https://github.com/geotools/geotools/pull/730 In addition to removing unnecessary code (an overridden CQL + operator), this also fixes a real issue in Cascaded Stored Query support th