Re: [Geotools-devel] Shapefile-Datastore

2019-03-14 Thread Andrea Aime
Hi, Generally speaking reading the file seems ok, there is a number of things that could use fixing but that can be discussed in a PR (e.g, no need for the absolute path, there are utilities to get a file extension, no need for the line number reader, exception eaten). I'd go ahead with a PR conta

Re: [Geotools-devel] Shapefile-Datastore

2019-03-13 Thread Burkhard Strauss
Fine, I am happy you're interested. So I will make one change at a time. I will start with the *.cpg file. The change will concern the DataStoreFactory and look like this (the green part is the addition): public DataStore createDataStore(Map params) throws IOException {     // ...  

Re: [Geotools-devel] Shapefile-Datastore

2019-03-12 Thread Andrea Aime
On Tue, Mar 12, 2019 at 7:41 PM Andrea Aime wrote: > Also, be patient, our ability to follow up on mail is limited by work, > family and other activities, it would not be strange if the turnaround > for mails or PRs takes several hours if not days. > Actually, before someone takes this statement

Re: [Geotools-devel] Shapefile-Datastore

2019-03-12 Thread Andrea Aime
Hi Eric, same answer as for Burkhard, changes are welcomed but you should "talk first" and have a bit of patience Cheers Andrea On Tue, Mar 12, 2019 at 6:03 PM Eric Engle wrote: > Semi-related, I have a few patches to enable proper random access (to the > dbf, and to the shp when an shx is avai

Re: [Geotools-devel] Shapefile-Datastore

2019-03-12 Thread Andrea Aime
Hi, improvements are often welcomed, but it's hard to tell unless you explain a bit how they are meant to be implemented, the "talk first" policy implies that one discusses the plan before implementation, or be ready to amend/start over in case the discussion brings the desired implementation in a

Re: [Geotools-devel] Shapefile-Datastore

2019-03-12 Thread Eric Engle via GeoTools-Devel
Semi-related, I have a few patches to enable proper random access (to the dbf, and to the shp when an shx is available or it's acceptable to build one). I'd also value ShpFiles support for Path, the Java NIO approach to reading files, that offers much greater flexibility in the implementation of r

[Geotools-devel] Shapefile-Datastore

2019-03-12 Thread Burkhard Strauss
Hi all, since GeoTools 17.0 I use a patched version of ShapefileDataStore to achieve the following: * some data providers provide  gzipped shapefiles (not *.shp/*.shx/*.dbf/*.prj but *.shp.gz/*.shx.gz/*.dbf.gz/*.prj.gz) Example: TomTom street map data. Support reading of such data. * s

Re: [Geotools-devel] Shapefile datastore changes definition of number attribute decimal count upon saving

2018-12-11 Thread Peilke, Hendrik
change the decimal count on writing to an existing shapefile (see below). Any ideas on this? Thanks, Hendrik Peilke Von: Peilke, Hendrik Gesendet: Dienstag, 27. November 2018 10:14 An: GeoTools-Devel@lists.sourceforge.net Betreff: [Geotools-devel] Shapefile datastore changes definition of number

Re: [Geotools-devel] Shapefile datastore does not support transactions and filters correctly

2018-11-29 Thread Andrea Aime
On Thu, Nov 29, 2018 at 10:24 AM Peilke, Hendrik wrote: > Hi Andrea, > > > > thanks for your answer. I think the basic design of the ifs (up until > filtering) is correct: Since the DiffFeatureReader can filter and sorts out > the modified features filtered by the native reader. Passing the query

Re: [Geotools-devel] Shapefile datastore does not support transactions and filters correctly

2018-11-29 Thread Peilke, Hendrik
ed, if the query is passed to the DiffFeatureReader, correct? Should I make a pull request for that? Regards, Hendrik Von: Andrea Aime Gesendet: Donnerstag, 29. November 2018 09:45 An: Peilke, Hendrik Cc: Geotools-Devel list Betreff: Re: [Geotools-devel] Shapefile datastore does not support t

Re: [Geotools-devel] Shapefile datastore does not support transactions and filters correctly

2018-11-29 Thread Andrea Aime
Hi, looking at the code, I believe that the chain of ifs in the area you're looking at is wrong... if there is a transaction going, from that point on any native support for filtering, sorting, paging should be foregone, because the DiffFeatureReeader is altering the reader contents with informatio

Re: [Geotools-devel] Shapefile datastore does not support transactions and filters correctly

2018-11-29 Thread Peilke, Hendrik
working as expected. If I would like to get all features source.getFeatures() would be the right thing to call. Von: Jody Garnett Gesendet: Donnerstag, 29. November 2018 02:11 An: Peilke, Hendrik Cc: GeoTools Developers Betreff: Re: [Geotools-devel] Shapefile datastore does not support

Re: [Geotools-devel] Shapefile datastore does not support transactions and filters correctly

2018-11-28 Thread Jody Garnett
At some level the writer needs to read over all the features (it needs to write out all the features), so passing a filter into the reader may act as a delete. On Tue, Nov 27, 2018 at 1:37 AM Peilke, Hendrik wrote: > Hi, > > > > I use a shapefile datastore in conjunction with a transaction. When

[Geotools-devel] Shapefile datastore does not support transactions and filters correctly

2018-11-27 Thread Peilke, Hendrik
Hi, I use a shapefile datastore in conjunction with a transaction. When reading features of the store, using a filter, I mentioned, that if I have a dirty state (added or modified features) in the transaction I always get all features returned regardless of the filter. I figured out that the p

[Geotools-devel] Shapefile datastore changes definition of number attribute decimal count upon saving

2018-11-27 Thread Peilke, Hendrik
Hi, when I use the shapefile datastore to open up an existing shapefile with a number attribute including a decimal count, then add a feature and finally save, I find the definitions of number columns changed: I initially have a number attribute with a field length of 18 and a decimal count of

Re: [Geotools-devel] Shapefile Datastore case sensitive

2008-01-22 Thread Jesse Eichar
It should be fixed now. Let me know if you still have problems. Jesse Le 22-Jan-08 à 3:03 AM, johann Sorel a écrit : > > hello, > > I tryed to open a file with a .SHP , he doesn't found it > He try to open the file but with a .shp end. > > It' not a big deal but really annoying when we have man

Re: [Geotools-devel] Shapefile Datastore case sensitive

2008-01-22 Thread johann Sorel
hello everyone, here is a new video of the map widget. (JDefaultEditableMap2D) http://altersig.developpez.com/demo/my.htm or http://altersig.developpez.com/demo/my.swf (second link is if the first one doesn't load) well, it's not completly working but getting closer. johann sorel __

[Geotools-devel] Shapefile Datastore case sensitive

2008-01-22 Thread johann Sorel
hello, I tryed to open a file with a .SHP , he doesn't found it He try to open the file but with a .shp end. It' not a big deal but really annoying when we have many shapes in .SHP . Here is the error message : java.io.FileNotFoundException: Shapefile not found:file:/home/eclesia/temp/GIS_PAS

Re: [Geotools-devel] Shapefile datastore

2008-01-15 Thread Jody Garnett
Jesse here on Jody's windows machine: I have solved that problem Andrea. It was the windows FileLocking that was deadlocking because there was one place where the lock wasn't released. But that is solved and now the temporary files are not all being deleted and that is causing problems. Shou

Re: [Geotools-devel] Shapefile datastore

2008-01-15 Thread Andrea Aime
Jesse Eichar ha scritto: > Naturally the wonderful windows platform doesn't like my work. So I > have to do some debugging there. Hum, yes, on windows the build deadlocks badly after throwing a slew of locking errors. Jesse, I haven't looked at the code, so I don't know if this helps, but in an

[Geotools-devel] Shapefile datastore

2008-01-14 Thread Jesse Eichar
Naturally the wonderful windows platform doesn't like my work. So I have to do some debugging there. jesse - Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anythi

[Geotools-devel] shapefile datastore problem

2007-07-05 Thread Fernando Gonzalez
I'm using ShapefileDataStore (GT2.3) and I have realized that it doesn't store null geometries in the way it should (well, or the way I think it should). If I set the default geometry of a feature to null, I write the shapefile and I read it again I get an empty geometry instead of a null. I have