Re: [Geotools-devel] Some date related failures in sql server

2015-06-13 Thread Andrea Aime
On Sat, Jun 13, 2015 at 8:09 PM, Ian Turton wrote: > Thanks Andrea, > > That sounds like what I expected. I'll check the PR in a moment. > I did not do a PR, committed directly, but check the commit anyways :-) Cheers Andrea -- == GeoServer Professional Services from the experts! Visit http:

Re: [Geotools-devel] Some date related failures in sql server

2015-06-13 Thread Ian Turton
Thanks Andrea, That sounds like what I expected. I'll check the PR in a moment. Ian On Sat, 13 Jun 2015 6:14 pm Andrea Aime wrote: > Hi Ian, > just committed this change: > > > https://github.com/geotools/geotools/commit/3cb85c8729ba8f9230103e40de6069fecc17a852 > > Pretty sure that was not the

Re: [Geotools-devel] Some date related failures in sql server

2015-06-13 Thread Andrea Aime
Hi Ian, just committed this change: https://github.com/geotools/geotools/commit/3cb85c8729ba8f9230103e40de6069fecc17a852 Pretty sure that was not the right way to do it (static formatter, and overriding FilterToSql code for date/timestamp handling). I do have a full pass here in sqlserver tests h

Re: [Geotools-devel] Some date related failures in sql server

2015-06-13 Thread Andrea Aime
Hi Ian, I've started up my local sql server windows machine, using the microsoft drivers like the build server, and the situation is even worse... I get all SQLServerTemporalFilterOnlineTest failing (they do not on the build server) with a time shift of 12 hours if I run them along with the rest of

Re: [Geotools-devel] Some date related failures in sql server

2015-06-13 Thread Andrea Aime
Hi Ian, thanks for looking into it. Maybe in parallel Jody/Torben can tell us if there is anything "special" about the sqlserver used for the tests, like special settings, and/or the timezone of the OS running it? Also, as far as I can see from the build, it's using the Microsoft SQL driver, inste

Re: [Geotools-devel] Some date related failures in sql server

2015-06-13 Thread Ian Turton
Looks like my work, I don't have a windows box to test on any longer but I'll have a look at the code and see what I can see. Ian On Sat, 13 Jun 2015 4:12 pm Andrea Aime wrote: > Hi, > it seems we still have 3 date related failures in sql server: > > Tests run: 4, Failures: 1, Errors: 0, Skippe

[Geotools-devel] Some date related failures in sql server

2015-06-13 Thread Andrea Aime
Hi, it seems we still have 3 date related failures in sql server: Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.921 sec <<< FAILURE! - in org.geotools.data.sqlserver.SQLServerDateOnlineTest testFiltersByDate(org.geotools.data.sqlserver.SQLServerDateOnlineTest) Time elapsed: 0.