Re: [Geotools-devel] Un-deprecating multi-font support in TextSymbolizer

2015-08-07 Thread Jody Garnett
If it helps merge could just be the API change - and not changing to rest if the code to use the list method until after 927. On Fri, Aug 7, 2015 at 3:51 AM Andrea Aime wrote: > On Fri, Aug 7, 2015 at 9:10 AM, Andrea Aime > wrote: > >> Eh, the proposal looks fine (take it as a +1), as I noted th

Re: [Geotools-devel] Un-deprecating multi-font support in TextSymbolizer

2015-08-07 Thread Andrea Aime
On Fri, Aug 7, 2015 at 3:30 PM, Jody Garnett wrote: > If it helps merge could just be the API change - and not changing to rest > if the code to use the list method until after 927. > Jody, whatever, provided it's done before today's midnight (your time). Starting monday I will not have time for

Re: [Geotools-devel] Un-deprecating multi-font support in TextSymbolizer

2015-08-07 Thread Jody Garnett
Okay lets round up vote feedback and get this (and the contrast enhancement) approved. On Fri, Aug 7, 2015 at 6:42 AM Andrea Aime wrote: > On Fri, Aug 7, 2015 at 3:30 PM, Jody Garnett > wrote: > >> If it helps merge could just be the API change - and not changing to rest >> if the code to use th

Re: [Geotools-devel] Un-deprecating multi-font support in TextSymbolizer

2015-08-07 Thread Andrea Aime
On Fri, Aug 7, 2015 at 9:10 AM, Andrea Aime wrote: > Eh, the proposal looks fine (take it as a +1), as I noted the pull request > is incomplete (will still loose the multifonts > along the way), and will cause quite a bit of conflicts with my current > work here (warning, branch still ongoing > a

Re: [Geotools-devel] Un-deprecating multi-font support in TextSymbolizer

2015-08-07 Thread Andrea Aime
On Thu, Aug 6, 2015 at 11:20 PM, Jody Garnett wrote: > Here is your proposal: > > https://github.com/geotools/geotools/wiki/Text-Symbolizer-Multi-font-support > > I will have a pull request for the API change shortly. > > Proposal is just for the API change, hooking up the multi-font rendering >

Re: [Geotools-devel] Un-deprecating multi-font support in TextSymbolizer

2015-08-07 Thread Andrea Aime
Btw, a note, I know I preach to always do proposals before coding, and I normally do. This one unfortunately caught me by surprise, I was not aware that the SE 1.1 work crippled the SLD 1.0 multifont support, and that the implementors were so carelessly throwing away functionality, I just noticed

Re: [Geotools-devel] Un-deprecating multi-font support in TextSymbolizer

2015-08-06 Thread Jody Garnett
Here is your proposal: https://github.com/geotools/geotools/wiki/Text-Symbolizer-Multi-font-support I will have a pull request for the API change shortly. Proposal is just for the API change, hooking up the multi-font rendering support is up to you :) -- Jody Garnett On 6 August 2015 at 02:06,

Re: [Geotools-devel] Un-deprecating multi-font support in TextSymbolizer

2015-08-06 Thread Andrea Aime
On Wed, Aug 5, 2015 at 6:09 PM, Jody Garnett wrote: > Quick +1 for restoring the functionality. > > Additional comments inline ... > > The methods in questions are in this interface: >> >> https://github.com/geotools/geotools/blob/master/modules/library/api/src/main/java/org/geotools/styling/Text

Re: [Geotools-devel] Un-deprecating multi-font support in TextSymbolizer

2015-08-05 Thread Jody Garnett
Quick +1 for restoring the functionality. Additional comments inline ... The methods in questions are in this interface: > > https://github.com/geotools/geotools/blob/master/modules/library/api/src/main/java/org/geotools/styling/TextSymbolizer.java#L321 > This is our GeoTools "shadow" read/write

[Geotools-devel] Un-deprecating multi-font support in TextSymbolizer

2015-08-05 Thread Andrea Aime
Hi, I would like to un-deprecate all the multi-font methods that have been deprecated for a while in GeoTools, and that utterly broke multi-font support for a number of years. The methods in questions are in this interface: https://github.com/geotools/geotools/blob/master/modules/library/api/src/m