Gabriel Roldán wrote:
> thanks Martin,
>
> so Jody complained that using a hint to pass namespace context onto
> FilterFactory would be like mixing construction and logic.
>
It won't break me if we are forced to ... it sounds like this
information is needed in order to construct correctly? I j
yes Martin, actually I thought of that due to that kind of examples.
And a nice effect on doing so is having Filter being namespace aware without
burdening the interfaces, as a property names is just that, an expression to
be evaluated at runtime.
Current implementations seems to be happy by just
Gabriel Roldán a écrit :
> so Jody complained that using a hint to pass namespace context onto
> FilterFactory would be like mixing construction and logic.
Maybe... But we already do that (as mentioned in my previous email). If we
didn't, it seems to me that the complexity level of referencing fa
Jody Garnett a écrit :
> I am a bit worried about the mixing of factory code and logic.
>
> Aside: In this case you are trying to stick additional context into the
> creation process ... that smacks of logic to me? FilterFactory is
> supposed to be stupid. An option would be to add the configurati
Gabriel Roldán a écrit :
> - Using Hints to pass "context" to a factory. Case being passing a set of
> prefix:namespace mappings to FilterFactory in order to make it namespace
> aware. As the prefixes mappings may change from invocation to invocation, it
> makes no sense to cache the factory ins
thanks Martin,
so Jody complained that using a hint to pass namespace context onto
FilterFactory would be like mixing construction and logic.
some comments inline
On Monday 28 May 2007 15:33:10 Martin Desruisseaux wrote:
> Gabriel Roldán a écrit :
> > PropertyAccessorFactory.createPropertyAcce
Gabriel Roldán a écrit :
> If I want to pass hints to FilterFactory, does it necessarly needs to declare
> which ones it accepts through getImplementationHints()?
Yes, you need to declares the hints are significant to FilterFactory. Note that
getImplementationHints() is significant only after Fil
Gabriel Roldán a écrit :
> PropertyAccessorFactory.createPropertyAccessor(...) receives a Hints.
> It is only called by PropertyAccessors.findPropertyAccessor, which should
> pass
> the Hints to PropertyAccessorFactory.createPropertyAccessor.
> In turn, PropertyAccessors.findPropertyAccessor gets
Hi guys,
Sorry to chime in late on this one. Has anything been reached. So I
beleive grabriel is right that there is no way to do hints with our
expression / api so doing it at the factory level is probably the way to go.
So... instead of getting out of control with containers and injection i
thi
Hi Jody,
agreed on avoiding mixing construction and logic.
I'm not so sure of the utility of a FilterBuilder _just_ to pass the context
to FilterFactory, where that could be accomplished by simple constructor
injection in the FilterFactory itself (in the geoserver side we're covered by
spring),
Hi Gabriel - a couple of thoughts
I am a bit worried about the mixing of factory code and logic.
Aside: In this case you are trying to stick additional context into the
creation process ... that smacks of logic to me? FilterFactory is
supposed to be stupid. An option would be to add the co
Thanks Jody,
so the next step is to know if that use of Hints is correct or not. Martin can
you confirm?
Sample scenarios:
- Using Hints to pass "context" to a factory. Case being passing a set of
prefix:namespace mappings to FilterFactory in order to make it namespace
aware. As the prefixes m
The Hint system was only recently hooked up - and I found a few problems
with it during that process. Please assume that any troubles you have
are just a QA problem (and something you can fix; and have permission to
fix).
For anything to do with runtime evaluation of filters you should look
in
btw,
If I want to pass hints to FilterFactory, does it necessarly needs to declare
which ones it accepts through getImplementationHints()?
I ask because I'm looking at GridCoverageFactory and, thgough it can handle
some hints at its constructor, it just returns an empty map in
getImplementation
Hi Justin,
I was trying to imeplement a namespace aware property accessor to work with
AttributeExpressionImpl, and got a bit confused on the use of Hints.
I could achieve the same result I'm looking for by hacking my own
FilterFactory implementation that creates namespace aware PropertyName
e
15 matches
Mail list logo
