Re: [Geotools-devel] feature collection cleanup pull request and update instructions

2012-10-31 Thread Jody Garnett
ichael Bedward > Cc: geotools-devel@lists.sourceforge.net > (mailto:geotools-devel@lists.sourceforge.net) > Subject: Re: [Geotools-devel] feature collection cleanup pull request and > update instructions > > > So could DefaultFeatureCollection.add be deprecate

Re: [Geotools-devel] feature collection cleanup pull request and update instructions

2012-10-31 Thread Brett Walker
= collection.iterator()) { ... } This is so much shorter. Brett From: Jody Garnett [mailto:jody.garn...@gmail.com] Sent: Thursday, 1 November 2012 10:05 AM To: Michael Bedward Cc: geotools-devel@lists.sourceforge.net Subject: Re: [Geotools-devel] feature collection cleanup pull request and update

Re: [Geotools-devel] feature collection cleanup pull request and update instructions

2012-10-31 Thread Michael Bedward
On 1 November 2012 09:03, Jody wrote: > I chose the same solution as you for the branch! > > Using a List and then ListFeatureCollection. > Cool. Great minds :) So could DefaultFeatureCollection.add be deprecated ? Michael ---

Re: [Geotools-devel] feature collection cleanup pull request and update instructions

2012-10-31 Thread Jody
I chose the same solution as you for the branch! Using a List and then ListFeatureCollection. I do want to see this applied shortly, I had some rebase troubles last night making the pull request causing a few curses on IRC. -- Jody Sent with Sparrow (http://www.sparrowmailapp.com/?sig) O

Re: [Geotools-devel] feature collection cleanup pull request and update instructions

2012-10-31 Thread Michael Bedward
Thanks Jody. A huge amount of work there ! A while ago I updated the feature tutorial to avoid using FeatureCollection.add, but instead of using DefaultFeatureCollection.add I explicitly created a List to accumulate features and then wrapped that in a ListFeatureCollection when writing to the Data

[Geotools-devel] feature collection cleanup pull request and update instructions

2012-10-31 Thread Jody Garnett
Pull request: - https://github.com/geotools/geotools/pull/44 Update instructions (These are copied from the update.rst file included in the pull request): - http://docs.codehaus.org/display/GEOTOOLS/FeatureCollection+revolution#FeatureCollectionrevolution-UpgradeInstructions -- Jody Garnett