Re: [Geotools-devel] featurecollection cleanup improvements

2012-11-03 Thread Jody Garnett
Bah that email got away from me - lets try again. > - commented out code: > https://github.com/geotools/geotools/commit/c0fd151d0265aa53b696010d0d995344c6533104#L6R1149 > > Yes this was a utility method when we removed the FeatureResults class; time for it to die (now removed). > - given ho

Re: [Geotools-devel] featurecollection cleanup improvements

2012-11-03 Thread Jody Garnett
> Hum.. a few things are clear by looking at the commit diff anyways: > - commented out code: > https://github.com/geotools/geotools/commit/c0fd151d0265aa53b696010d0d995344c6533104#L6R1149 > - given how generics work, isn't this method redundand with respect > the one right below it? > https://gith

Re: [Geotools-devel] featurecollection cleanup improvements

2012-11-03 Thread Andrea Aime
On Sat, Nov 3, 2012 at 4:19 PM, Andrea Aime wrote: > It would be nice to see how the whole looks now, but it seems you are making > changes in another branch. > If you had committed them in the same branch where you made the original > pull request github would have updated the pull request with i

Re: [Geotools-devel] featurecollection cleanup improvements

2012-11-03 Thread Andrea Aime
On Sat, Nov 3, 2012 at 3:36 PM, Jody Garnett wrote: > Updated the pull request in response to feedback from Andrea and Micheal. > > - DataUtilities.close( Iterator ) > - DataUtilities.first( SimpleFeatureCollection ): SimpleFeature > - DataUtilities.first( FeatureCollection ): F > - DataUtilities.

[Geotools-devel] featurecollection cleanup improvements

2012-11-03 Thread Jody Garnett
Updated the pull request in response to feedback from Andrea and Micheal. - DataUtilities.close( Iterator ) - DataUtilities.first( SimpleFeatureCollection ): SimpleFeature - DataUtilities.first( FeatureCollection ): F - DataUtilities.list( FeatureCollection ): List // Already existed - DataUtil